Re: [PATCH v2 05/11] fblog: register one fblog object per framebuffer

Hi Joe On Mon, Jul 9, 2012 at 12:13 AM, Joe Perches wrote: > On Sun, 2012-07-08 at 23:56 +0200, David Herrmann wrote: >> > > Hi David. Trivial comments only: > >> diff --git a/drivers/video/console/fblog.c b/drivers/video/console/fblog.c > [] >> @@ -23,15 +23,204 @@ >> * all fblog instances be

Re: [PATCH v2 05/11] fblog: register one fblog object per framebuffer

On Sun, 2012-07-08 at 23:56 +0200, David Herrmann wrote: > Hi David. Trivial comments only: > diff --git a/drivers/video/console/fblog.c b/drivers/video/console/fblog.c [] > @@ -23,15 +23,204 @@ > * all fblog instances before running other graphics applications. > */ Please add #define pr_f

[PATCH v2 05/11] fblog: register one fblog object per framebuffer

One fblog object is associated to each registered framebuffer. This way, we can draw the console to each framebuffer. When a framebuffer driver unregisters a framebuffer, we also unregister our fblog object. That is, our lifetime is coupled to the lifetime of the framebuffer. However, this does not