Re: [PATCH v2 05/17] locks: generic_delete_lease doesn't need a file_lock at all

2015-01-12 Thread NeilBrown
On Mon, 12 Jan 2015 18:25:00 -0500 Jeff Layton wrote: > On Tue, 13 Jan 2015 12:03:43 +1300 > NeilBrown wrote: > > > On Thu, 4 Sep 2014 08:38:31 -0400 Jeff Layton > > wrote: > > > > > Ensure that it's OK to pass in a NULL file_lock double pointer on > > > a F_UNLCK request and convert the vfs

Re: [PATCH v2 05/17] locks: generic_delete_lease doesn't need a file_lock at all

2015-01-12 Thread Jeff Layton
On Tue, 13 Jan 2015 12:03:43 +1300 NeilBrown wrote: > On Thu, 4 Sep 2014 08:38:31 -0400 Jeff Layton > wrote: > > > Ensure that it's OK to pass in a NULL file_lock double pointer on > > a F_UNLCK request and convert the vfs_setlease F_UNLCK callers to > > do just that. > > > > Finally, turn th

Re: [PATCH v2 05/17] locks: generic_delete_lease doesn't need a file_lock at all

2015-01-12 Thread NeilBrown
On Thu, 4 Sep 2014 08:38:31 -0400 Jeff Layton wrote: > Ensure that it's OK to pass in a NULL file_lock double pointer on > a F_UNLCK request and convert the vfs_setlease F_UNLCK callers to > do just that. > > Finally, turn the BUG_ON in generic_setlease into a WARN_ON_ONCE > with an error retur

Re: [PATCH v2 05/17] locks: generic_delete_lease doesn't need a file_lock at all

2014-09-04 Thread Jeff Layton
On Thu, 4 Sep 2014 13:14:24 -0700 Christoph Hellwig wrote: > On Thu, Sep 04, 2014 at 08:38:31AM -0400, Jeff Layton wrote: > > Ensure that it's OK to pass in a NULL file_lock double pointer on > > a F_UNLCK request and convert the vfs_setlease F_UNLCK callers to > > do just that. > > > > Finally,

Re: [PATCH v2 05/17] locks: generic_delete_lease doesn't need a file_lock at all

2014-09-04 Thread Christoph Hellwig
On Thu, Sep 04, 2014 at 08:38:31AM -0400, Jeff Layton wrote: > Ensure that it's OK to pass in a NULL file_lock double pointer on > a F_UNLCK request and convert the vfs_setlease F_UNLCK callers to > do just that. > > Finally, turn the BUG_ON in generic_setlease into a WARN_ON_ONCE > with an error

[PATCH v2 05/17] locks: generic_delete_lease doesn't need a file_lock at all

2014-09-04 Thread Jeff Layton
Ensure that it's OK to pass in a NULL file_lock double pointer on a F_UNLCK request and convert the vfs_setlease F_UNLCK callers to do just that. Finally, turn the BUG_ON in generic_setlease into a WARN_ON_ONCE with an error return. That's a problem we can handle without crashing the box if it occ