Re: [PATCH v2 05/29] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues

2020-07-14 Thread Martin K. Petersen
Lee, > Yes, I spotted it. Hence my earlier comment to Hannes: > > "Look at the function below it (in your local copy). ;)" > > Do you want me to fix that up here as well? I can fix it up. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 05/29] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues

2020-07-14 Thread Lee Jones
On Tue, 14 Jul 2020, Martin K. Petersen wrote: > > Lee, Ah, you are alive. I was beginning to worry. :) I have more fixes for you, but didn't want to send them until these have been merged. > > @@ -3015,9 +3016,8 @@ static void fcoe_ctlr_disc_recv(struct fc_lport > > *lport, struct fc_frame

Re: [PATCH v2 05/29] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues

2020-07-14 Thread Martin K. Petersen
Lee, > @@ -3015,9 +3016,8 @@ static void fcoe_ctlr_disc_recv(struct fc_lport *lport, > struct fc_frame *fp) > fc_frame_free(fp); > } > > -/** > +/* > * fcoe_ctlr_disc_recv - start discovery for VN2VN mode. > - * @fip: The FCoE controller > * > * This sets a flag indicating that

Re: [PATCH v2 05/29] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues

2020-07-14 Thread Lee Jones
On Tue, 14 Jul 2020, Hannes Reinecke wrote: > On 7/13/20 9:46 AM, Lee Jones wrote: > > Mostly missing or incorrect (bitrotted) function parameters. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/scsi/fcoe/fcoe_ctlr.c:139: warning: Function parameter or member > >

Re: [PATCH v2 05/29] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues

2020-07-14 Thread Hannes Reinecke
On 7/13/20 9:46 AM, Lee Jones wrote: Mostly missing or incorrect (bitrotted) function parameters. Fixes the following W=1 kernel build warning(s): drivers/scsi/fcoe/fcoe_ctlr.c:139: warning: Function parameter or member 'mode' not described in 'fcoe_ctlr_init'

[PATCH v2 05/29] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues

2020-07-13 Thread Lee Jones
Mostly missing or incorrect (bitrotted) function parameters. Fixes the following W=1 kernel build warning(s): drivers/scsi/fcoe/fcoe_ctlr.c:139: warning: Function parameter or member 'mode' not described in 'fcoe_ctlr_init' drivers/scsi/fcoe/fcoe_ctlr.c:604: warning: Function parameter or