Re: [PATCH v2 06/10] nvme/core: add mdev interfaces

2019-05-06 Thread Christoph Hellwig
On Mon, May 06, 2019 at 11:31:27AM +0300, Maxim Levitsky wrote: > Why are you saying that? I actualy prefer to use a sepearate queue per > software > nvme controller, tat because of lower overhead (about half than going through > the block layer) and it better at QoS as the separate queue (or

Re: [PATCH v2 06/10] nvme/core: add mdev interfaces

2019-05-06 Thread Maxim Levitsky
On Mon, 2019-05-06 at 11:31 +0300, Maxim Levitsky wrote: > On Sat, 2019-05-04 at 08:49 +0200, Christoph Hellwig wrote: > > On Fri, May 03, 2019 at 10:00:54PM +0300, Max Gurtovoy wrote: > > > Don't see a big difference of taking NVMe queue and namespace/partition > > > to > > > guest OS or to P2P

Re: [PATCH v2 06/10] nvme/core: add mdev interfaces

2019-05-06 Thread Maxim Levitsky
On Sat, 2019-05-04 at 08:49 +0200, Christoph Hellwig wrote: > On Fri, May 03, 2019 at 10:00:54PM +0300, Max Gurtovoy wrote: > > Don't see a big difference of taking NVMe queue and namespace/partition to > > guest OS or to P2P since IO is issued by external entity and pooled outside > > the pci

Re: [PATCH v2 06/10] nvme/core: add mdev interfaces

2019-05-04 Thread Christoph Hellwig
On Fri, May 03, 2019 at 10:00:54PM +0300, Max Gurtovoy wrote: > Don't see a big difference of taking NVMe queue and namespace/partition to > guest OS or to P2P since IO is issued by external entity and pooled outside > the pci driver. We are not going to the queue aside either way.. That is

Re: [PATCH v2 06/10] nvme/core: add mdev interfaces

2019-05-03 Thread Max Gurtovoy
On 5/3/2019 3:29 PM, Christoph Hellwig wrote: On Thu, May 02, 2019 at 02:47:57PM +0300, Maxim Levitsky wrote: If the mdev device driver also sets the NVME_F_MDEV_DMA_SUPPORTED, the mdev core will dma map all the guest memory into the nvme device, so that nvme device driver can use dma

Re: [PATCH v2 06/10] nvme/core: add mdev interfaces

2019-05-03 Thread Christoph Hellwig
On Thu, May 02, 2019 at 02:47:57PM +0300, Maxim Levitsky wrote: > If the mdev device driver also sets the > NVME_F_MDEV_DMA_SUPPORTED, the mdev core will > dma map all the guest memory into the nvme device, > so that nvme device driver can use dma addresses as passed > from the mdev core driver

[PATCH v2 06/10] nvme/core: add mdev interfaces

2019-05-02 Thread Maxim Levitsky
This adds infrastructure for a nvme-mdev to attach to the core driver, to be able to know which nvme controllers are present and which namespaces they have. It also adds an interface to nvme device drivers which expose the its queues in a controlled manner to the nvme mdev core driver. A driver