Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi All, On 03/21/2017 03:10 AM, Ulf Hansson wrote: > On 20 March 2017 at 12:00, Philipp Zabel wrote: >> On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: >>> On 20.03.2017 11:27, Philipp Zabel wrote: >> [...] diff --git a/include/linux/reset.h

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi All, On 03/21/2017 03:10 AM, Ulf Hansson wrote: > On 20 March 2017 at 12:00, Philipp Zabel wrote: >> On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: >>> On 20.03.2017 11:27, Philipp Zabel wrote: >> [...] diff --git a/include/linux/reset.h b/include/linux/reset.h index

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 20 March 2017 at 12:00, Philipp Zabel wrote: > On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: >> On 20.03.2017 11:27, Philipp Zabel wrote: > [...] >> > diff --git a/include/linux/reset.h b/include/linux/reset.h >> > index 86b4ed75359e8..c905ff1c21ec6 100644 >>

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 20 March 2017 at 12:00, Philipp Zabel wrote: > On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: >> On 20.03.2017 11:27, Philipp Zabel wrote: > [...] >> > diff --git a/include/linux/reset.h b/include/linux/reset.h >> > index 86b4ed75359e8..c905ff1c21ec6 100644 >> > ---

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 20 March 2017 at 12:00, Philipp Zabel wrote: > On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: >> On 20.03.2017 11:27, Philipp Zabel wrote: > [...] >> > diff --git a/include/linux/reset.h b/include/linux/reset.h >> > index 86b4ed75359e8..c905ff1c21ec6 100644 >>

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 20 March 2017 at 12:00, Philipp Zabel wrote: > On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: >> On 20.03.2017 11:27, Philipp Zabel wrote: > [...] >> > diff --git a/include/linux/reset.h b/include/linux/reset.h >> > index 86b4ed75359e8..c905ff1c21ec6 100644 >> > ---

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: > On 20.03.2017 11:27, Philipp Zabel wrote: [...] > > diff --git a/include/linux/reset.h b/include/linux/reset.h > > index 86b4ed75359e8..c905ff1c21ec6 100644 > > --- a/include/linux/reset.h > > +++ b/include/linux/reset.h > > @@ -74,14

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: > On 20.03.2017 11:27, Philipp Zabel wrote: [...] > > diff --git a/include/linux/reset.h b/include/linux/reset.h > > index 86b4ed75359e8..c905ff1c21ec6 100644 > > --- a/include/linux/reset.h > > +++ b/include/linux/reset.h > > @@ -74,14

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 20.03.2017 11:27, Philipp Zabel wrote: > Hi Andrzej, > > On Mon, 2017-03-20 at 11:03 +0100, Andrzej Hajda wrote: >> Hi Philipp, >> >> On 20.03.2017 10:53, Philipp Zabel wrote: >>> On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: Hi Philipp, Todays next branch does not work

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 20.03.2017 11:27, Philipp Zabel wrote: > Hi Andrzej, > > On Mon, 2017-03-20 at 11:03 +0100, Andrzej Hajda wrote: >> Hi Philipp, >> >> On 20.03.2017 10:53, Philipp Zabel wrote: >>> On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: Hi Philipp, Todays next branch does not work

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi Andrzej, On Mon, 2017-03-20 at 11:03 +0100, Andrzej Hajda wrote: > Hi Philipp, > > On 20.03.2017 10:53, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: > >> Hi Philipp, > >> > >> Todays next branch does not work with exynos5433-tm2 board. > >> I guess this

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi Andrzej, On Mon, 2017-03-20 at 11:03 +0100, Andrzej Hajda wrote: > Hi Philipp, > > On 20.03.2017 10:53, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: > >> Hi Philipp, > >> > >> Todays next branch does not work with exynos5433-tm2 board. > >> I guess this

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi Philipp, On 20.03.2017 10:53, Philipp Zabel wrote: > On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: >> Hi Philipp, >> >> Todays next branch does not work with exynos5433-tm2 board. >> I guess this patch causes regression. On MMC without reset controller I >> get errors: >> [

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi Philipp, On 20.03.2017 10:53, Philipp Zabel wrote: > On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: >> Hi Philipp, >> >> Todays next branch does not work with exynos5433-tm2 board. >> I guess this patch causes regression. On MMC without reset controller I >> get errors: >> [

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: > Hi Philipp, > > Todays next branch does not work with exynos5433-tm2 board. > I guess this patch causes regression. On MMC without reset controller I > get errors: > [4.938222] dwmmc_exynos 1554.mshc: platform data not available >

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: > Hi Philipp, > > Todays next branch does not work with exynos5433-tm2 board. > I guess this patch causes regression. On MMC without reset controller I > get errors: > [4.938222] dwmmc_exynos 1554.mshc: platform data not available >

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi Philipp, Todays next branch does not work with exynos5433-tm2 board. I guess this patch causes regression. On MMC without reset controller I get errors: [4.938222] dwmmc_exynos 1554.mshc: platform data not available [4.943268] dwmmc_exynos: probe of 1554.mshc failed with error

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi Philipp, Todays next branch does not work with exynos5433-tm2 board. I guess this patch causes regression. On MMC without reset controller I get errors: [4.938222] dwmmc_exynos 1554.mshc: platform data not available [4.943268] dwmmc_exynos: probe of 1554.mshc failed with error

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 15 March 2017 at 12:31, Philipp Zabel wrote: > As of commit bb475230b8e5 ("reset: make optional functions really > optional"), the reset framework API calls use NULL pointers to describe > optional, non-present reset controls. > > This allows to return errors from

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 15 March 2017 at 12:31, Philipp Zabel wrote: > As of commit bb475230b8e5 ("reset: make optional functions really > optional"), the reset framework API calls use NULL pointers to describe > optional, non-present reset controls. > > This allows to return errors from

[PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

As of commit bb475230b8e5 ("reset: make optional functions really optional"), the reset framework API calls use NULL pointers to describe optional, non-present reset controls. This allows to return errors from devm_reset_control_get_optional and to call reset_control_(de)assert unconditionally.

[PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

As of commit bb475230b8e5 ("reset: make optional functions really optional"), the reset framework API calls use NULL pointers to describe optional, non-present reset controls. This allows to return errors from devm_reset_control_get_optional and to call reset_control_(de)assert unconditionally.