Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-04-04 Thread Yinghai Lu
On Thu, Apr 4, 2013 at 11:27 AM, Tejun Heo wrote: >> for (no = 0; no < ACPI_OVERRIDE_TABLES; no++) { >> + /* >> + * have to use unsigned long, otherwise 32bit spit warning >> + * and it is ok to unsigned long, as bootloader would not >> + *

Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-04-04 Thread Yinghai Lu
On Thu, Apr 4, 2013 at 11:30 AM, Tejun Heo wrote: > Also the comment contradicts with what you wrote in the next patch. > > Boot loader could load initrd above max_low_pfn. It does not contradict: this patch: bootloader would not load initrd above 4G for 32bit kernel max_low_pfn is below 4G.

Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-04-04 Thread Tejun Heo
On Thu, Apr 04, 2013 at 11:27:42AM -0700, Tejun Heo wrote: > > + /* > > +* have to use unsigned long, otherwise 32bit spit warning > > +* and it is ok to unsigned long, as bootloader would not > > +* load initrd above 4G for 32bit kernel. > > +

Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-04-04 Thread Tejun Heo
On Sat, Mar 09, 2013 at 10:44:33PM -0800, Yinghai Lu wrote: > In 32bit we will find table with phys address during 32bit flat mode > in head_32.S, because at that time we don't need set page table to > access initrd. > > For copying we could use early_ioremap() with phys directly before mem

Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-04-04 Thread Tejun Heo
On Sat, Mar 09, 2013 at 10:44:33PM -0800, Yinghai Lu wrote: In 32bit we will find table with phys address during 32bit flat mode in head_32.S, because at that time we don't need set page table to access initrd. For copying we could use early_ioremap() with phys directly before mem mapping

Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-04-04 Thread Tejun Heo
On Thu, Apr 04, 2013 at 11:27:42AM -0700, Tejun Heo wrote: + /* +* have to use unsigned long, otherwise 32bit spit warning +* and it is ok to unsigned long, as bootloader would not +* load initrd above 4G for 32bit kernel. +*/ +

Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-04-04 Thread Yinghai Lu
On Thu, Apr 4, 2013 at 11:30 AM, Tejun Heo t...@kernel.org wrote: Also the comment contradicts with what you wrote in the next patch. Boot loader could load initrd above max_low_pfn. It does not contradict: this patch: bootloader would not load initrd above 4G for 32bit kernel max_low_pfn

Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-04-04 Thread Yinghai Lu
On Thu, Apr 4, 2013 at 11:27 AM, Tejun Heo t...@kernel.org wrote: for (no = 0; no ACPI_OVERRIDE_TABLES; no++) { + /* + * have to use unsigned long, otherwise 32bit spit warning + * and it is ok to unsigned long, as bootloader would not +

[PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-03-09 Thread Yinghai Lu
In 32bit we will find table with phys address during 32bit flat mode in head_32.S, because at that time we don't need set page table to access initrd. For copying we could use early_ioremap() with phys directly before mem mapping is set. To keep 32bit and 64bit consistent, use phys_addr for all.

[PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

2013-03-09 Thread Yinghai Lu
In 32bit we will find table with phys address during 32bit flat mode in head_32.S, because at that time we don't need set page table to access initrd. For copying we could use early_ioremap() with phys directly before mem mapping is set. To keep 32bit and 64bit consistent, use phys_addr for all.