On 27.04.20 16:00:43, Borislav Petkov wrote: > On Wed, Apr 22, 2020 at 01:58:11PM +0200, Robert Richter wrote: > > The struct is used to store temporary data for the dmidecode callback. > > Clean this up a bit: > > > > 1) Rename member count to index since this is what it is used for. > > > > 2) Move code close to ghes_edac_dmidecode() where it is used. > > > > 3) While at it, use edac_get_dimm_by_index(). > > > > Signed-off-by: Robert Richter <rrich...@marvell.com> > > --- > > drivers/edac/ghes_edac.c | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > Ok except the commit title is wrong. And yes, pls keep it "dimm_fill" - > short and sweet and without yet another "ghes" in the name. :)
Fixed the title. Thanks, -Robert
