Re: [PATCH v2 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

2018-02-22 Thread Evan Green
Hi Lina, On Thu, Feb 22, 2018 at 8:58 AM, Lina Iyer wrote: > On Wed, Feb 21 2018 at 22:07 +, Evan Green wrote: >> >> Hi Lina, >> >> On Thu, Feb 15, 2018 at 9:35 AM, Lina Iyer wrote: > > [...] > >>> +static struct cache_req *cache_rpm_request(struct rpmh_client *rc, >>> +

Re: [PATCH v2 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

2018-02-22 Thread Lina Iyer
On Wed, Feb 21 2018 at 22:07 +, Evan Green wrote: Hi Lina, On Thu, Feb 15, 2018 at 9:35 AM, Lina Iyer wrote: [...] +static struct cache_req *cache_rpm_request(struct rpmh_client *rc, + enum rpmh_state state, +

Re: [PATCH v2 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

2018-02-21 Thread Evan Green
Hi Lina, On Thu, Feb 15, 2018 at 9:35 AM, Lina Iyer wrote: > Active state requests are sent immediately to the mailbox controller, > while sleep and wake state requests are cached in this driver to avoid > taxing the mailbox controller repeatedly. The cached values will be sent > to the controlle

[PATCH v2 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

2018-02-15 Thread Lina Iyer
Active state requests are sent immediately to the mailbox controller, while sleep and wake state requests are cached in this driver to avoid taxing the mailbox controller repeatedly. The cached values will be sent to the controller when the rpmh_flush() is called. Generally, flushing is a system P