Re: [PATCH v2 07/10] media/usb/pvrusb2: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Mike Isely
The code you've added is carefully checking the return pointer from pvr2_hdw_get_ctrl_v4l() yet the original code did not operate this way. The result is that now there's this "unbalanced" effect where it appears that the validity of the pvr2_ctrl instance is only checked on one side of the i

[PATCH v2 07/10] media/usb/pvrusb2: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Ricardo Ribalda Delgado
This driver does not use the control infrastructure. Add support for the new field which on structure v4l2_ext_controls Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drive