Re: [PATCH v2 07/11] firmware: split firmware fallback functionality into its own file

2018-03-07 Thread Luis R. Rodriguez
On Wed, Feb 28, 2018 at 08:11:31AM +0100, Greg KH wrote: > On Tue, Feb 27, 2018 at 09:33:28PM -0800, Kees Cook wrote: > > On Tue, Feb 27, 2018 at 5:28 PM, Luis R. Rodriguez > > wrote: > > > On Tue, Feb 27, 2018 at 03:14:53PM -0800, Kees Cook wrote: > > >> On Fri, Feb 23, 2018 at 6:46 PM, Luis R.

Re: [PATCH v2 07/11] firmware: split firmware fallback functionality into its own file

2018-02-27 Thread Greg KH
On Tue, Feb 27, 2018 at 09:33:28PM -0800, Kees Cook wrote: > On Tue, Feb 27, 2018 at 5:28 PM, Luis R. Rodriguez wrote: > > On Tue, Feb 27, 2018 at 03:14:53PM -0800, Kees Cook wrote: > >> On Fri, Feb 23, 2018 at 6:46 PM, Luis R. Rodriguez > >> wrote: > >> > The firmware fallback code is optional.

Re: [PATCH v2 07/11] firmware: split firmware fallback functionality into its own file

2018-02-27 Thread Kees Cook
On Tue, Feb 27, 2018 at 5:28 PM, Luis R. Rodriguez wrote: > On Tue, Feb 27, 2018 at 03:14:53PM -0800, Kees Cook wrote: >> On Fri, Feb 23, 2018 at 6:46 PM, Luis R. Rodriguez wrote: >> > The firmware fallback code is optional. Split that code out to help >> > distinguish the fallback functionlity f

Re: [PATCH v2 07/11] firmware: split firmware fallback functionality into its own file

2018-02-27 Thread Luis R. Rodriguez
On Tue, Feb 27, 2018 at 03:14:53PM -0800, Kees Cook wrote: > On Fri, Feb 23, 2018 at 6:46 PM, Luis R. Rodriguez wrote: > > The firmware fallback code is optional. Split that code out to help > > distinguish the fallback functionlity from othere core firmware loader > > features. This should make i

Re: [PATCH v2 07/11] firmware: split firmware fallback functionality into its own file

2018-02-27 Thread Kees Cook
On Fri, Feb 23, 2018 at 6:46 PM, Luis R. Rodriguez wrote: > The firmware fallback code is optional. Split that code out to help > distinguish the fallback functionlity from othere core firmware loader > features. This should make it easier to maintain and review code > changes. > > The reason for

[PATCH v2 07/11] firmware: split firmware fallback functionality into its own file

2018-02-23 Thread Luis R. Rodriguez
The firmware fallback code is optional. Split that code out to help distinguish the fallback functionlity from othere core firmware loader features. This should make it easier to maintain and review code changes. The reason for keeping the configuration onto a table which is built-in if you enable

[PATCH v2 07/11] firmware: split firmware fallback functionality into its own file

2018-02-13 Thread Luis R. Rodriguez
The firmware fallback code is optional. Split that code out to help distinguish the fallback functionlity from othere core firmware loader features. This should make it easier to maintain and review code changes. This introduces no functional changes. Signed-off-by: Luis R. Rodriguez --- driver