Re: [PATCH v2 07/12] mm/hugetlb: do not modify user provided gfp_mask

2020-06-09 Thread Joonsoo Kim
2020년 6월 9일 (화) 오후 10:54, Michal Hocko 님이 작성: > > On Wed 27-05-20 15:44:58, Joonsoo Kim wrote: > > From: Joonsoo Kim > > > > It's not good practice to modify user input. Instead of using it to > > build correct gfp_mask for APIs, this patch introduces another gfp_mask > > field, __gfp_mask, for in

Re: [PATCH v2 07/12] mm/hugetlb: do not modify user provided gfp_mask

2020-06-09 Thread Michal Hocko
On Wed 27-05-20 15:44:58, Joonsoo Kim wrote: > From: Joonsoo Kim > > It's not good practice to modify user input. Instead of using it to > build correct gfp_mask for APIs, this patch introduces another gfp_mask > field, __gfp_mask, for internal usage. Ugh, this is really ugly. It is just hugetlb

[PATCH v2 07/12] mm/hugetlb: do not modify user provided gfp_mask

2020-05-26 Thread js1304
From: Joonsoo Kim It's not good practice to modify user input. Instead of using it to build correct gfp_mask for APIs, this patch introduces another gfp_mask field, __gfp_mask, for internal usage. Signed-off-by: Joonsoo Kim --- mm/hugetlb.c | 19 ++- mm/internal.h | 2 ++ 2 f