Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-15 Thread Peter Chen
On Tue, Jul 15, 2014 at 05:24:37PM +0200, Antoine Ténart wrote: > Hi, > > On Thu, Jul 03, 2014 at 08:17:34AM +0530, punnaiah choudary kalluri wrote: > > Since its a generic driver, support for configuring the dma_mask using > > dma_coerce_mask_and_coherent would be good. > > > > Should I add a D

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-15 Thread Peter Chen
On Tue, Jul 15, 2014 at 05:22:30PM +0200, Antoine Ténart wrote: > Hi guys, > > On Wed, Jul 02, 2014 at 01:10:00AM +, Peter Chen wrote: > > > On 07/01/2014 02:42 PM, Alexandre Belloni wrote: > > > > > > > Well, there is nothing specific about the Berlin CI. Some > > > > subsystems use

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-15 Thread Antoine Ténart
Hi, On Thu, Jul 03, 2014 at 08:17:34AM +0530, punnaiah choudary kalluri wrote: > Since its a generic driver, support for configuring the dma_mask using > dma_coerce_mask_and_coherent would be good. > Should I add a DMA mask dt property? Or just not add this and wait for someone needing it in his

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-15 Thread Antoine Ténart
Hi guys, On Wed, Jul 02, 2014 at 01:10:00AM +, Peter Chen wrote: > > On 07/01/2014 02:42 PM, Alexandre Belloni wrote: > > > > > Well, there is nothing specific about the Berlin CI. Some > > > subsystems use the 'generic' keyword in these cases. Do you see a > > > particular reason

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-02 Thread punnaiah choudary kalluri
Since its a generic driver, support for configuring the dma_mask using dma_coerce_mask_and_coherent would be good. Regards, Punnaiah On Tue, Jun 24, 2014 at 4:05 PM, Antoine Ténart wrote: > Add a generic ChipIdea driver, with optional PHY and clock, to support > ChipIdea controllers that doesn't

RE: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-01 Thread Peter Chen
> > Hello. > > On 07/01/2014 02:42 PM, Alexandre Belloni wrote: > > > Well, there is nothing specific about the Berlin CI. Some > > subsystems use the 'generic' keyword in these cases. Do you see a > > particular reason I should use some Berlin related compatible here? > > No

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-01 Thread Sergei Shtylyov
Hello. On 07/01/2014 02:42 PM, Alexandre Belloni wrote: Well, there is nothing specific about the Berlin CI. Some subsystems use the 'generic' keyword in these cases. Do you see a particular reason I should use some Berlin related compatible here? Not must, one suggestion is: can you change

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-01 Thread Alexandre Belloni
On 01/07/2014 at 16:30:08 +0800, Peter Chen wrote : > > >>Well, there is nothing specific about the Berlin CI. Some subsystems > > >>use the 'generic' keyword in these cases. Do you see a particular reason > > >>I should use some Berlin related compatible here? > > > > > >Not must, one suggestion i

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-01 Thread Peter Chen
On Tue, Jul 01, 2014 at 10:55:37AM +0200, Sebastian Hesselbarth wrote: > On 07/01/2014 02:21 AM, Peter Chen wrote: > >On Mon, Jun 30, 2014 at 03:33:13PM +0200, Antoine Ténart wrote: > >>On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote: > >>>On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoin

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-01 Thread Sebastian Hesselbarth
On 07/01/2014 02:21 AM, Peter Chen wrote: On Mon, Jun 30, 2014 at 03:33:13PM +0200, Antoine Ténart wrote: On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote: On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine Ténart wrote: + +static const struct of_device_id ci_hdrc_generic_of_match[] =

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-01 Thread Antoine Ténart
Peter, On Tue, Jul 01, 2014 at 08:21:14AM +0800, Peter Chen wrote: > On Mon, Jun 30, 2014 at 03:33:13PM +0200, Antoine Ténart wrote: > > On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote: > > > On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine Ténart wrote: > > > > > > > > ifneq ($(CON

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-30 Thread Peter Chen
On Mon, Jun 30, 2014 at 03:33:13PM +0200, Antoine Ténart wrote: > Peter, > > On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote: > > On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine Ténart wrote: > > > > > > ifneq ($(CONFIG_OF),) > > > obj-$(CONFIG_USB_CHIPIDEA) += usbmisc_imx.o

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-30 Thread Antoine Ténart
Hello, On Tue, Jun 24, 2014 at 07:51:01PM +0900, Jingoo Han wrote: > On Tuesday, June 24, 2014 7:35 PM, Antoine Tenart wrote: > > > > Add a generic ChipIdea driver, with optional PHY and clock, to support > > ChipIdea controllers that doesn't need specific functions. > > s/doesn't/don't > > >

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-30 Thread Antoine Ténart
Peter, On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote: > On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine Ténart wrote: > > > > ifneq ($(CONFIG_OF),) > > obj-$(CONFIG_USB_CHIPIDEA) += usbmisc_imx.o ci_hdrc_imx.o > > + obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_generic.o

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-26 Thread Peter Chen
On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote: > On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine Ténart wrote: > > Add a generic ChipIdea driver, with optional PHY and clock, to support > > ChipIdea controllers that doesn't need specific functions. > > > > + return 0; > > +} > > +

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-26 Thread Peter Chen
On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine Ténart wrote: > Add a generic ChipIdea driver, with optional PHY and clock, to support > ChipIdea controllers that doesn't need specific functions. > > Needed for the Marvell Berlin SoCs SUB controllers. > > Signed-off-by: Antoine Ténart > --- >

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-24 Thread Jingoo Han
On Tuesday, June 24, 2014 7:35 PM, Antoine Tenart wrote: > > Add a generic ChipIdea driver, with optional PHY and clock, to support > ChipIdea controllers that doesn't need specific functions. s/doesn't/don't > > Needed for the Marvell Berlin SoCs SUB controllers. s/SUB/USB > Signed-off-by: A

[PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-24 Thread Antoine Ténart
Add a generic ChipIdea driver, with optional PHY and clock, to support ChipIdea controllers that doesn't need specific functions. Needed for the Marvell Berlin SoCs SUB controllers. Signed-off-by: Antoine Ténart --- drivers/usb/chipidea/Makefile | 1 + drivers/usb/chipidea/ci_hdrc_ge