Re: [PATCH v2 07/15] Simplify the confusing HIWORD_UPDATE scheme.

2016-09-02 Thread Bjorn Helgaas
On Fri, Sep 02, 2016 at 02:38:06PM -0700, Guenter Roeck wrote: > On Fri, Sep 02, 2016 at 10:54:53AM -0500, Bjorn Helgaas wrote: > > +#define HIWORD_UPDATE(mask, val) ((mask << 16) | val) > > + > > +#define ENCODE_LANES(x)(((x >> 1) & 3) << 4) > > (x) ? Done, thanks! (And

Re: [PATCH v2 07/15] Simplify the confusing HIWORD_UPDATE scheme.

2016-09-02 Thread Bjorn Helgaas
On Fri, Sep 02, 2016 at 02:38:06PM -0700, Guenter Roeck wrote: > On Fri, Sep 02, 2016 at 10:54:53AM -0500, Bjorn Helgaas wrote: > > +#define HIWORD_UPDATE(mask, val) ((mask << 16) | val) > > + > > +#define ENCODE_LANES(x)(((x >> 1) & 3) << 4) > > (x) ? Done, thanks! (And

Re: [PATCH v2 07/15] Simplify the confusing HIWORD_UPDATE scheme.

2016-09-02 Thread Guenter Roeck
On Fri, Sep 02, 2016 at 10:54:53AM -0500, Bjorn Helgaas wrote: > > --- > drivers/pci/host/pcie-rockchip.c | 70 > +- > 1 file changed, 24 insertions(+), 46 deletions(-) > > diff --git a/drivers/pci/host/pcie-rockchip.c > b/drivers/pci/host/pcie-rockchip.c

Re: [PATCH v2 07/15] Simplify the confusing HIWORD_UPDATE scheme.

2016-09-02 Thread Guenter Roeck
On Fri, Sep 02, 2016 at 10:54:53AM -0500, Bjorn Helgaas wrote: > > --- > drivers/pci/host/pcie-rockchip.c | 70 > +- > 1 file changed, 24 insertions(+), 46 deletions(-) > > diff --git a/drivers/pci/host/pcie-rockchip.c > b/drivers/pci/host/pcie-rockchip.c

[PATCH v2 07/15] Simplify the confusing HIWORD_UPDATE scheme.

2016-09-02 Thread Bjorn Helgaas
--- drivers/pci/host/pcie-rockchip.c | 70 +- 1 file changed, 24 insertions(+), 46 deletions(-) diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index c0c3ad5..b204567 100644 --- a/drivers/pci/host/pcie-rockchip.c +++

[PATCH v2 07/15] Simplify the confusing HIWORD_UPDATE scheme.

2016-09-02 Thread Bjorn Helgaas
--- drivers/pci/host/pcie-rockchip.c | 70 +- 1 file changed, 24 insertions(+), 46 deletions(-) diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index c0c3ad5..b204567 100644 --- a/drivers/pci/host/pcie-rockchip.c +++