Re: [PATCH v2 07/18] nitro_enclaves: Init misc device providing the ioctl interface

2020-05-26 Thread Paraschiv, Andra-Irina
On 26/05/2020 09:42, Greg KH wrote: On Mon, May 25, 2020 at 11:49:50PM +0300, Paraschiv, Andra-Irina wrote: On 22/05/2020 10:07, Greg KH wrote: On Fri, May 22, 2020 at 09:29:35AM +0300, Andra Paraschiv wrote: +static char *ne_cpus; +module_param(ne_cpus, charp, 0644); +MODULE_PARM_DESC(ne_c

Re: [PATCH v2 07/18] nitro_enclaves: Init misc device providing the ioctl interface

2020-05-25 Thread Greg KH
On Mon, May 25, 2020 at 11:49:50PM +0300, Paraschiv, Andra-Irina wrote: > > > On 22/05/2020 10:07, Greg KH wrote: > > On Fri, May 22, 2020 at 09:29:35AM +0300, Andra Paraschiv wrote: > > > +static char *ne_cpus; > > > +module_param(ne_cpus, charp, 0644); > > > +MODULE_PARM_DESC(ne_cpus, " - CPU p

Re: [PATCH v2 07/18] nitro_enclaves: Init misc device providing the ioctl interface

2020-05-25 Thread Paraschiv, Andra-Irina
On 22/05/2020 10:07, Greg KH wrote: On Fri, May 22, 2020 at 09:29:35AM +0300, Andra Paraschiv wrote: +static char *ne_cpus; +module_param(ne_cpus, charp, 0644); +MODULE_PARM_DESC(ne_cpus, " - CPU pool used for Nitro Enclaves"); This is not the 1990's, don't use module parameters if you can he

Re: [PATCH v2 07/18] nitro_enclaves: Init misc device providing the ioctl interface

2020-05-22 Thread Greg KH
On Fri, May 22, 2020 at 09:29:35AM +0300, Andra Paraschiv wrote: > +static char *ne_cpus; > +module_param(ne_cpus, charp, 0644); > +MODULE_PARM_DESC(ne_cpus, " - CPU pool used for Nitro Enclaves"); This is not the 1990's, don't use module parameters if you can help it. Why is this needed, and wher

[PATCH v2 07/18] nitro_enclaves: Init misc device providing the ioctl interface

2020-05-21 Thread Andra Paraschiv
The Nitro Enclaves driver provides an ioctl interface to the user space for enclave lifetime management e.g. enclave creation / termination and setting enclave resources such as memory and CPU. This ioctl interface is mapped to a Nitro Enclaves misc device. Signed-off-by: Andra Paraschiv --- dr