Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Wed, Sep 27, 2017 at 03:27:01PM -0500, Alan Tull wrote: > On Fri, Sep 22, 2017 at 2:28 AM, Wu Hao wrote: > > On Wed, Sep 20, 2017 at 04:24:10PM -0500, Alan Tull wrote: > > HI Hao, Hi Alan Thanks for your comments. :) > > >> a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Wed, Sep 27, 2017 at 03:27:01PM -0500, Alan Tull wrote: > On Fri, Sep 22, 2017 at 2:28 AM, Wu Hao wrote: > > On Wed, Sep 20, 2017 at 04:24:10PM -0500, Alan Tull wrote: > > HI Hao, Hi Alan Thanks for your comments. :) > > >> a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao > >> wrote:

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Fri, Sep 22, 2017 at 2:28 AM, Wu Hao wrote: > On Wed, Sep 20, 2017 at 04:24:10PM -0500, Alan Tull wrote: HI Hao, >> a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: >> >> Hi Hao, >> >> I'm done with some board bringup so I have time to look at

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Fri, Sep 22, 2017 at 2:28 AM, Wu Hao wrote: > On Wed, Sep 20, 2017 at 04:24:10PM -0500, Alan Tull wrote: HI Hao, >> a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: >> >> Hi Hao, >> >> I'm done with some board bringup so I have time to look at your patchset >> again. > > Hi Alan

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Thu, Sep 21, 2017 at 02:58:57PM -0500, Alan Tull wrote: > )On Wed, Sep 20, 2017 at 4:24 PM, Alan Tull wrote: > > Hi Hao, > > A few more minor things below. Hi Alan Thanks for your comments, will fix them in the next version. Thanks Hao > > > a (wh., *()On Sun, Jun 25,

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Thu, Sep 21, 2017 at 02:58:57PM -0500, Alan Tull wrote: > )On Wed, Sep 20, 2017 at 4:24 PM, Alan Tull wrote: > > Hi Hao, > > A few more minor things below. Hi Alan Thanks for your comments, will fix them in the next version. Thanks Hao > > > a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM,

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Wed, Sep 20, 2017 at 04:24:10PM -0500, Alan Tull wrote: > a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > > Hi Hao, > > I'm done with some board bringup so I have time to look at your patchset > again. Hi Alan Thanks for your time on the review. : ) > >

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Wed, Sep 20, 2017 at 04:24:10PM -0500, Alan Tull wrote: > a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > > Hi Hao, > > I'm done with some board bringup so I have time to look at your patchset > again. Hi Alan Thanks for your time on the review. : ) > > Something I can't

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

)On Wed, Sep 20, 2017 at 4:24 PM, Alan Tull wrote: Hi Hao, A few more minor things below. > a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > > Hi Hao, > > I'm done with some board bringup so I have time to look at your patchset > again. > >

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

)On Wed, Sep 20, 2017 at 4:24 PM, Alan Tull wrote: Hi Hao, A few more minor things below. > a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > > Hi Hao, > > I'm done with some board bringup so I have time to look at your patchset > again. > > Something I can't help but notice is

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: Hi Hao, I'm done with some board bringup so I have time to look at your patchset again. Something I can't help but notice is that this patchset will be almost completely reusable for embedded FPGAs if the enumeration

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: Hi Hao, I'm done with some board bringup so I have time to look at your patchset again. Something I can't help but notice is that this patchset will be almost completely reusable for embedded FPGAs if the enumeration is separated from

RE: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

> On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > > From: Xiao Guangrong > > > > Device Feature List structure creates a link list of feature headers > > within the MMIO space to provide an extensible way of adding features. > > > > The Intel

RE: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

> On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > > From: Xiao Guangrong > > > > Device Feature List structure creates a link list of feature headers > > within the MMIO space to provide an extensible way of adding features. > > > > The Intel FPGA PCIe driver walks through the feature headers

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > From: Xiao Guangrong > > Device Feature List structure creates a link list of feature headers > within the MMIO space to provide an extensible way of adding features. > > The Intel FPGA PCIe driver

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > From: Xiao Guangrong > > Device Feature List structure creates a link list of feature headers > within the MMIO space to provide an extensible way of adding features. > > The Intel FPGA PCIe driver walks through the feature headers to enumerate >

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Thu, Jul 13, 2017 at 12:52:30PM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > > From: Xiao Guangrong > > > > Device Feature List structure creates a link list of feature headers > > within the MMIO space to provide

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Thu, Jul 13, 2017 at 12:52:30PM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > > From: Xiao Guangrong > > > > Device Feature List structure creates a link list of feature headers > > within the MMIO space to provide an extensible way of adding features. > > > > The

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > From: Xiao Guangrong > > Device Feature List structure creates a link list of feature headers > within the MMIO space to provide an extensible way of adding features. > > The Intel FPGA PCIe driver

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > From: Xiao Guangrong > > Device Feature List structure creates a link list of feature headers > within the MMIO space to provide an extensible way of adding features. > > The Intel FPGA PCIe driver walks through the feature headers to enumerate >

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Mon, Jun 26, 2017 at 1:42 PM, Moritz Fischer wrote: Hi Hao, I'll be out until July 5. I'll be able to start looking at this v2 after that. Alan > Hi Xiao / Wu, > > general question, can't you make the /* */ comments > for the structs kernel-doc ([1]) markup instead (see

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Mon, Jun 26, 2017 at 1:42 PM, Moritz Fischer wrote: Hi Hao, I'll be out until July 5. I'll be able to start looking at this v2 after that. Alan > Hi Xiao / Wu, > > general question, can't you make the /* */ comments > for the structs kernel-doc ([1]) markup instead (see below)? > > > On

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Mon, Jun 26, 2017 at 11:42:05AM -0700, Moritz Fischer wrote: > Hi Xiao / Wu, > > general question, can't you make the /* */ comments > for the structs kernel-doc ([1]) markup instead (see below)? Hi Moritz, Thanks for your review. Sure, will fix this issue for all patches. Hao > > > On

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

On Mon, Jun 26, 2017 at 11:42:05AM -0700, Moritz Fischer wrote: > Hi Xiao / Wu, > > general question, can't you make the /* */ comments > for the structs kernel-doc ([1]) markup instead (see below)? Hi Moritz, Thanks for your review. Sure, will fix this issue for all patches. Hao > > > On

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

Hi Xiao / Wu, general question, can't you make the /* */ comments for the structs kernel-doc ([1]) markup instead (see below)? On Mon, Jun 26, 2017 at 09:52:03AM +0800, Wu Hao wrote: > From: Xiao Guangrong > > Device Feature List structure creates a link list

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

Hi Xiao / Wu, general question, can't you make the /* */ comments for the structs kernel-doc ([1]) markup instead (see below)? On Mon, Jun 26, 2017 at 09:52:03AM +0800, Wu Hao wrote: > From: Xiao Guangrong > > Device Feature List structure creates a link list of feature headers > within the

[PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

From: Xiao Guangrong Device Feature List structure creates a link list of feature headers within the MMIO space to provide an extensible way of adding features. The Intel FPGA PCIe driver walks through the feature headers to enumerate feature devices, FPGA

[PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

From: Xiao Guangrong Device Feature List structure creates a link list of feature headers within the MMIO space to provide an extensible way of adding features. The Intel FPGA PCIe driver walks through the feature headers to enumerate feature devices, FPGA Management Engine (FME) and FPGA Port