Re: [PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface

2019-05-06 Thread Maxim Levitsky
On Fri, 2019-05-03 at 06:09 -0600, Keith Busch wrote: > On Fri, May 03, 2019 at 12:20:17AM +0300, Maxim Levitsky wrote: > > On Thu, 2019-05-02 at 15:12 -0600, Heitke, Kenneth wrote: > > > On 5/2/2019 5:47 AM, Maxim Levitsky wrote: > > > > +static void nvme_ext_queue_free(struct nvme_ctrl *ctrl,

Re: [PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface

2019-05-03 Thread Keith Busch
On Fri, May 03, 2019 at 12:20:17AM +0300, Maxim Levitsky wrote: > On Thu, 2019-05-02 at 15:12 -0600, Heitke, Kenneth wrote: > > On 5/2/2019 5:47 AM, Maxim Levitsky wrote: > > > +static void nvme_ext_queue_free(struct nvme_ctrl *ctrl, u16 qid) > > > +{ > > > + struct nvme_dev *dev =

Re: [PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface

2019-05-02 Thread Maxim Levitsky
On Thu, 2019-05-02 at 15:12 -0600, Heitke, Kenneth wrote: > > On 5/2/2019 5:47 AM, Maxim Levitsky wrote: > > Note that currently the number of hw queues reserved for mdev, > > has to be pre determined on module load. > > > > (I used to allocate the queues dynamicaly on demand, but > > recent

Re: [PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface

2019-05-02 Thread Heitke, Kenneth
On 5/2/2019 5:47 AM, Maxim Levitsky wrote: Note that currently the number of hw queues reserved for mdev, has to be pre determined on module load. (I used to allocate the queues dynamicaly on demand, but recent changes to allocate polled/read queues made this somewhat difficult, so I dropped

Re: [PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface

2019-05-02 Thread Maxim Levitsky
On Thu, 2019-05-02 at 14:47 +0300, Maxim Levitsky wrote: > Note that currently the number of hw queues reserved for mdev, > has to be pre determined on module load. > > (I used to allocate the queues dynamicaly on demand, but > recent changes to allocate polled/read queues made > this somewhat

[PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface

2019-05-02 Thread Maxim Levitsky
Note that currently the number of hw queues reserved for mdev, has to be pre determined on module load. (I used to allocate the queues dynamicaly on demand, but recent changes to allocate polled/read queues made this somewhat difficult, so I dropped this for now) Signed-off-by: Maxim Levitsky