Re: [PATCH v2 08/15] slab: use __GFP_COMP flag for allocating slab pages

2013-10-18 Thread JoonSoo Kim
2013/10/18 Christoph Lameter : > On Wed, 16 Oct 2013, Joonsoo Kim wrote: > >> If we use 'struct page' of first page as 'struct slab', there is no >> advantage not to use __GFP_COMP. So use __GFP_COMP flag for all the cases. > > Yes this is going to make the allocators behave in the same way. We cou

Re: [PATCH v2 08/15] slab: use __GFP_COMP flag for allocating slab pages

2013-10-17 Thread Christoph Lameter
On Wed, 16 Oct 2013, Joonsoo Kim wrote: > If we use 'struct page' of first page as 'struct slab', there is no > advantage not to use __GFP_COMP. So use __GFP_COMP flag for all the cases. Yes this is going to make the allocators behave in the same way. We could actually put some of the page alloca

[PATCH v2 08/15] slab: use __GFP_COMP flag for allocating slab pages

2013-10-16 Thread Joonsoo Kim
If we use 'struct page' of first page as 'struct slab', there is no advantage not to use __GFP_COMP. So use __GFP_COMP flag for all the cases. Signed-off-by: Joonsoo Kim diff --git a/mm/slab.c b/mm/slab.c index f9e676e..75c6082 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -1718,15 +1718,6 @@ static