Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver

2016-05-23 Thread Rich Felker
On Mon, May 23, 2016 at 10:32:35PM +0200, Daniel Lezcano wrote: > On Fri, May 20, 2016 at 11:15:16PM -0400, Rich Felker wrote: > > On Fri, May 20, 2016 at 04:01:56PM +0200, Daniel Lezcano wrote: > > > On Fri, May 20, 2016 at 02:53:04AM +, Rich Felker wrote: > > > > Signed-off-by: Rich Felker >

Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver

2016-05-23 Thread Daniel Lezcano
On Fri, May 20, 2016 at 11:15:16PM -0400, Rich Felker wrote: > On Fri, May 20, 2016 at 04:01:56PM +0200, Daniel Lezcano wrote: > > On Fri, May 20, 2016 at 02:53:04AM +, Rich Felker wrote: > > > Signed-off-by: Rich Felker > > > --- > > > > Hi Rich, > > > > please add a nice changelog describi

Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver

2016-05-21 Thread Rob Landley
On 05/20/2016 10:15 PM, Rich Felker wrote: > On Fri, May 20, 2016 at 04:01:56PM +0200, Daniel Lezcano wrote: >>> + return ((u64)sechi << 32 | seclo) * 10 + nsec; >> >> s/10/NSEC_PER_SEC/ ... >>> + hwirq = irq_get_irq_data(pit_irq)->hwirq; >>> + enable_val = (1<<26) | ((hwirq&0

Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver

2016-05-20 Thread Rich Felker
On Fri, May 20, 2016 at 04:01:56PM +0200, Daniel Lezcano wrote: > On Fri, May 20, 2016 at 02:53:04AM +, Rich Felker wrote: > > Signed-off-by: Rich Felker > > --- > > Hi Rich, > > please add a nice changelog describing how works the timer. OK. Do you prefer this in changelog, comments in the

Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver

2016-05-20 Thread Daniel Lezcano
On Fri, May 20, 2016 at 02:53:04AM +, Rich Felker wrote: > Signed-off-by: Rich Felker > --- Hi Rich, please add a nice changelog describing how works the timer. Having openhardware is really awesome and that deserves a nice documentation. I noticed the changelog of this patchset it very lig

[PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver

2016-05-19 Thread Rich Felker
Signed-off-by: Rich Felker --- My previous post of the patch series accidentally omitted omitted Cc'ing of subsystem maintainers for the necessary clocksource, irqchip, and spi drivers. Please ack if this looks ok because I want to get it merged as part of the arch/sh pull request for 4.7. drive