Re: [PATCH v2 09/15] KVM: MMU: introduce pte-list lockless walker

2013-09-16 Thread Gleb Natapov
On Mon, Sep 16, 2013 at 09:52:26PM +0800, Xiao Guangrong wrote: > Hi Gleb, > > On 09/16/2013 08:42 PM, Gleb Natapov wrote: > > >> static unsigned long *__gfn_to_rmap(gfn_t gfn, int level, > >>struct kvm_memory_slot *slot) > >> { > >> @@ -4651,7 +4700,7 @@ int kvm

Re: [PATCH v2 09/15] KVM: MMU: introduce pte-list lockless walker

2013-09-16 Thread Xiao Guangrong
Hi Gleb, On 09/16/2013 08:42 PM, Gleb Natapov wrote: >> static unsigned long *__gfn_to_rmap(gfn_t gfn, int level, >> struct kvm_memory_slot *slot) >> { >> @@ -4651,7 +4700,7 @@ int kvm_mmu_module_init(void) >> { >> pte_list_desc_cache = kmem_cache_create("

Re: [PATCH v2 09/15] KVM: MMU: introduce pte-list lockless walker

2013-09-16 Thread Gleb Natapov
On Thu, Sep 05, 2013 at 06:29:12PM +0800, Xiao Guangrong wrote: > The basic idea is from nulls list which uses a nulls to indicate > whether the desc is moved to different pte-list > > Note, we should do bottom-up walk in the desc since we always move > the bottom entry to the deleted position. A

Re: [PATCH v2 09/15] KVM: MMU: introduce pte-list lockless walker

2013-09-08 Thread Xiao Guangrong
On Sep 5, 2013, at 6:29 PM, Xiao Guangrong wrote: > > A desc only has 3 entries > in the current code so it is not a problem now, but the issue will > be triggered if we expend the size of desc in the further development Sorry, this description is obvious wrong, the bug exists even if 3 entri

[PATCH v2 09/15] KVM: MMU: introduce pte-list lockless walker

2013-09-05 Thread Xiao Guangrong
The basic idea is from nulls list which uses a nulls to indicate whether the desc is moved to different pte-list Note, we should do bottom-up walk in the desc since we always move the bottom entry to the deleted position. A desc only has 3 entries in the current code so it is not a problem now, bu