Re: [PATCH v2 09/16] block: sed-opal: split generation of bytestring header and content

2019-01-19 Thread Scott Bauer
On Thu, Jan 17, 2019 at 09:31:49PM +, David Kozub wrote: > - > - memcpy(&cmd->cmd[cmd->pos], bytestring, len); > + start = &cmd->cmd[cmd->pos]; > cmd->pos += len; This is somewhat pendatic, but it helps me review patches if we keep things together. Since we're no longer doing th

[PATCH v2 09/16] block: sed-opal: split generation of bytestring header and content

2019-01-17 Thread David Kozub
From: Jonas Rabenstein Split the header generation from the (normal) memcpy part if a bytestring is copied into the command buffer. This allows in-place generation of the bytestring content. For example, copy_from_user may be used without an intermediate buffer. Signed-off-by: Jonas Rabenstein