Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hi Benjamin, Nestor, On Tue, 2018-03-06 at 00:31 +0100, Florent Flament wrote: > On Mon, 2018-03-05 at 18:26 +0100, Benjamin Tissoires wrote: > > Hi Florent, > > Hi Benjamin, > > > > > On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado > > wrote: > > > Hello

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hi Benjamin, Nestor, On Tue, 2018-03-06 at 00:31 +0100, Florent Flament wrote: > On Mon, 2018-03-05 at 18:26 +0100, Benjamin Tissoires wrote: > > Hi Florent, > > Hi Benjamin, > > > > > On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado > > wrote: > > > Hello Florent, > > > > > > In my

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

On Mon, 2018-03-05 at 18:26 +0100, Benjamin Tissoires wrote: > Hi Florent, Hi Benjamin, > > On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado > wrote: > > Hello Florent, > > > > In my view, this driver may not be a good idea. The default > > behaviour > > of K290

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

On Mon, 2018-03-05 at 18:26 +0100, Benjamin Tissoires wrote: > Hi Florent, Hi Benjamin, > > On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado > wrote: > > Hello Florent, > > > > In my view, this driver may not be a good idea. The default > > behaviour > > of K290 is 'send multimedia

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

On Mon, 2018-03-05 at 10:31 +0100, Nestor Lopez Casado wrote: > Hello Florent, Hi Nestor, > In my view, this driver may not be a good idea. The default behaviour > of K290 is 'send multimedia keycodes' with the user given the choice > to change that behaviour via vendor commands. Putting a

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

On Mon, 2018-03-05 at 10:31 +0100, Nestor Lopez Casado wrote: > Hello Florent, Hi Nestor, > In my view, this driver may not be a good idea. The default behaviour > of K290 is 'send multimedia keycodes' with the user given the choice > to change that behaviour via vendor commands. Putting a

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hi Florent, Thank you for the patch! Yet something to improve: [auto build test ERROR on hid/for-next] [also build test ERROR on v4.16-rc4 next-20180305] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hi Florent, Thank you for the patch! Yet something to improve: [auto build test ERROR on hid/for-next] [also build test ERROR on v4.16-rc4 next-20180305] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hi Florent, On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado wrote: > Hello Florent, > > In my view, this driver may not be a good idea. The default behaviour > of K290 is 'send multimedia keycodes' with the user given the choice > to change that behaviour via

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hi Florent, On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado wrote: > Hello Florent, > > In my view, this driver may not be a good idea. The default behaviour > of K290 is 'send multimedia keycodes' with the user given the choice > to change that behaviour via vendor commands. Putting a

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hi Florent, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hid/for-next] [also build test WARNING on v4.16-rc4 next-20180305] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hi Florent, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hid/for-next] [also build test WARNING on v4.16-rc4 next-20180305] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hello Florent, In my view, this driver may not be a good idea. The default behaviour of K290 is 'send multimedia keycodes' with the user given the choice to change that behaviour via vendor commands. Putting a driver that will unconditionally change that behaviour without the user's consent might

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

Hello Florent, In my view, this driver may not be a good idea. The default behaviour of K290 is 'send multimedia keycodes' with the user given the choice to change that behaviour via vendor commands. Putting a driver that will unconditionally change that behaviour without the user's consent might

[PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

With the generic HID driver, K290 keyboards' F1 to F12 keys send multimedia events by default, and standard keycodes when the function key is pressed. This driver allows to configure K290 keyboards, so that F1 to F12 have a standard behavior and send multimedia events when the function key is

[PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

With the generic HID driver, K290 keyboards' F1 to F12 keys send multimedia events by default, and standard keycodes when the function key is pressed. This driver allows to configure K290 keyboards, so that F1 to F12 have a standard behavior and send multimedia events when the function key is