Re: [PATCH v2 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

2014-06-03 Thread Mika Westerberg
On Mon, Jun 02, 2014 at 02:12:07PM -0700, eric.er...@linux.intel.com wrote: > + WARN((readl(conf_reg) & BYT_DIRECTIRQ), > + "Potential Error: Setting GPIO with direct_irq_en to output"); Also you don't need parentheses here. -- To unsubscribe from this list: send the line

Re: [PATCH v2 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

2014-06-03 Thread Mika Westerberg
On Mon, Jun 02, 2014 at 02:12:07PM -0700, eric.er...@linux.intel.com wrote: > From: Eric Ernst > > For Baytrail, you should never set a GPIO set to direct_irq > to output mode. When direct_irq_en is set for a GPIO, it is > tied directly to an APIC internally, and making the pad output > does

Re: [PATCH v2 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

2014-06-03 Thread Mika Westerberg
On Mon, Jun 02, 2014 at 02:12:07PM -0700, eric.er...@linux.intel.com wrote: From: Eric Ernst eric.er...@linux.intel.com For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the

Re: [PATCH v2 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

2014-06-03 Thread Mika Westerberg
On Mon, Jun 02, 2014 at 02:12:07PM -0700, eric.er...@linux.intel.com wrote: + WARN((readl(conf_reg) BYT_DIRECTIRQ), + Potential Error: Setting GPIO with direct_irq_en to output); Also you don't need parentheses here. -- To unsubscribe from this list: send the line unsubscribe

[PATCH v2 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

2014-06-02 Thread eric . ernst
From: Eric Ernst For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the pad output does not make any sense. Assert a WARN() in the event this happens. Signed-off-by: Eric Ernst

[PATCH v2 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

2014-06-02 Thread eric . ernst
From: Eric Ernst eric.er...@linux.intel.com For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the pad output does not make any sense. Assert a WARN() in the event this happens.