Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/20/2016 02:38 AM, David Rivshin (Allworx) wrote: > On Tue, 19 Apr 2016 18:43:39 -0400 (EDT) > David Miller wrote: > >> From: Grygorii Strashko >> Date: Tue, 19 Apr 2016 21:44:09 +0300 >> >>> May be you can send revert + your patch 1 (only fix

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/20/2016 02:38 AM, David Rivshin (Allworx) wrote: > On Tue, 19 Apr 2016 18:43:39 -0400 (EDT) > David Miller wrote: > >> From: Grygorii Strashko >> Date: Tue, 19 Apr 2016 21:44:09 +0300 >> >>> May be you can send revert + your patch 1 (only fix for this issue). >>> >>> Dave, Does that sound

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On Tue, 19 Apr 2016 18:43:39 -0400 (EDT) David Miller wrote: > From: Grygorii Strashko > Date: Tue, 19 Apr 2016 21:44:09 +0300 > > > May be you can send revert + your patch 1 (only fix for this issue). > > > > Dave, Does that sound good to you?

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On Tue, 19 Apr 2016 18:43:39 -0400 (EDT) David Miller wrote: > From: Grygorii Strashko > Date: Tue, 19 Apr 2016 21:44:09 +0300 > > > May be you can send revert + your patch 1 (only fix for this issue). > > > > Dave, Does that sound good to you? > > Sure. OK, I will hopefully have that

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

From: Grygorii Strashko Date: Tue, 19 Apr 2016 21:44:09 +0300 > May be you can send revert + your patch 1 (only fix for this issue). > > Dave, Does that sound good to you? Sure.

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

From: Grygorii Strashko Date: Tue, 19 Apr 2016 21:44:09 +0300 > May be you can send revert + your patch 1 (only fix for this issue). > > Dave, Does that sound good to you? Sure.

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/19/2016 08:14 PM, David Rivshin (Allworx) wrote: On Tue, 19 Apr 2016 18:44:41 +0300 Grygorii Strashko wrote: On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: On Tue, 19 Apr 2016 17:41:07 +0300 Grygorii Strashko wrote: Hi, On

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/19/2016 08:14 PM, David Rivshin (Allworx) wrote: On Tue, 19 Apr 2016 18:44:41 +0300 Grygorii Strashko wrote: On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: On Tue, 19 Apr 2016 17:41:07 +0300 Grygorii Strashko wrote: Hi, On 04/19/2016 04:56 PM, Andrew Goodbody wrote: Adding

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 19/04/16 10:14, David Rivshin (Allworx) wrote: >> Ah Ok. There are no user of cpsw_platform_data outside of net/ethernet/ti/, >> so yes, looks like your patch 1 does exactly what's needed. > > Given that the v1 of Andrew's patch is already in Dave's net tree, and > would obviously have many

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 19/04/16 10:14, David Rivshin (Allworx) wrote: >> Ah Ok. There are no user of cpsw_platform_data outside of net/ethernet/ti/, >> so yes, looks like your patch 1 does exactly what's needed. > > Given that the v1 of Andrew's patch is already in Dave's net tree, and > would obviously have many

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On Tue, 19 Apr 2016 18:44:41 +0300 Grygorii Strashko wrote: > On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: > > On Tue, 19 Apr 2016 17:41:07 +0300 > > Grygorii Strashko wrote: > > > >> Hi, > >> > >> On 04/19/2016 04:56 PM, Andrew

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On Tue, 19 Apr 2016 18:44:41 +0300 Grygorii Strashko wrote: > On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: > > On Tue, 19 Apr 2016 17:41:07 +0300 > > Grygorii Strashko wrote: > > > >> Hi, > >> > >> On 04/19/2016 04:56 PM, Andrew Goodbody wrote: > >>> Adding a 2nd PHY to cpsw

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

From: Grygorii Strashko Date: Tue, 19 Apr 2016 17:41:07 +0300 > David, Is it possible to drop prev version of this patch from linux-next > - it breaks boot on many TI boards with -next. It doesn't work that way, I cannot "drop" patches. One has to send me a fix to the

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

From: Grygorii Strashko Date: Tue, 19 Apr 2016 17:41:07 +0300 > David, Is it possible to drop prev version of this patch from linux-next > - it breaks boot on many TI boards with -next. It doesn't work that way, I cannot "drop" patches. One has to send me a fix to the existing patch, or a

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: > On Tue, 19 Apr 2016 17:41:07 +0300 > Grygorii Strashko wrote: > >> Hi, >> >> On 04/19/2016 04:56 PM, Andrew Goodbody wrote: >>> Adding a 2nd PHY to cpsw results in a NULL pointer dereference >>> as below. Fix by

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: > On Tue, 19 Apr 2016 17:41:07 +0300 > Grygorii Strashko wrote: > >> Hi, >> >> On 04/19/2016 04:56 PM, Andrew Goodbody wrote: >>> Adding a 2nd PHY to cpsw results in a NULL pointer dereference >>> as below. Fix by maintaining a reference to

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On Tue, 19 Apr 2016 17:41:07 +0300 Grygorii Strashko wrote: > Hi, > > On 04/19/2016 04:56 PM, Andrew Goodbody wrote: > > Adding a 2nd PHY to cpsw results in a NULL pointer dereference > > as below. Fix by maintaining a reference to each PHY node in slave > > struct

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On Tue, 19 Apr 2016 17:41:07 +0300 Grygorii Strashko wrote: > Hi, > > On 04/19/2016 04:56 PM, Andrew Goodbody wrote: > > Adding a 2nd PHY to cpsw results in a NULL pointer dereference > > as below. Fix by maintaining a reference to each PHY node in slave > > struct instead of a single reference

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Hi, On 04/19/2016 04:56 PM, Andrew Goodbody wrote: > Adding a 2nd PHY to cpsw results in a NULL pointer dereference > as below. Fix by maintaining a reference to each PHY node in slave > struct instead of a single reference in the priv struct which was > overwritten by the 2nd PHY. David, Is it

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Hi, On 04/19/2016 04:56 PM, Andrew Goodbody wrote: > Adding a 2nd PHY to cpsw results in a NULL pointer dereference > as below. Fix by maintaining a reference to each PHY node in slave > struct instead of a single reference in the priv struct which was > overwritten by the 2nd PHY. David, Is it

[PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Adding a 2nd PHY to cpsw results in a NULL pointer dereference as below. Fix by maintaining a reference to each PHY node in slave struct instead of a single reference in the priv struct which was overwritten by the 2nd PHY. [ 17.870933] Unable to handle kernel NULL pointer dereference at

[PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Adding a 2nd PHY to cpsw results in a NULL pointer dereference as below. Fix by maintaining a reference to each PHY node in slave struct instead of a single reference in the priv struct which was overwritten by the 2nd PHY. [ 17.870933] Unable to handle kernel NULL pointer dereference at

[PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Adding a 2nd PHY to cpsw results in a NULL pointer dereference as below. Fix by maintaining a reference to each PHY node in slave struct instead of a single reference in the priv struct which was overwritten by the 2nd PHY. [ 17.870933] Unable to handle kernel NULL pointer dereference at

[PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Adding a 2nd PHY to cpsw results in a NULL pointer dereference as below. Fix by maintaining a reference to each PHY node in slave struct instead of a single reference in the priv struct which was overwritten by the 2nd PHY. [ 17.870933] Unable to handle kernel NULL pointer dereference at