Re: [PATCH v2 1/1] fs/ceph: make logical calculation functions return bool

2016-05-06 Thread Yan, Zheng
26.com [mailto:hellozzy1...@126.com] On Behalf Of >> Zhang Zhuoyu >> Sent: Friday, March 25, 2016 5:19 PM >> To: ceph-de...@vger.kernel.org >> Cc: s...@redhat.com; z...@redhat.com; idryo...@gmail.com; linux- >> ker...@vger.kernel.org; Zhang Zhuoyu >> >> S

Re: [PATCH v2 1/1] fs/ceph: make logical calculation functions return bool

2016-05-06 Thread Ilya Dryomov
On Fri, May 6, 2016 at 9:24 AM, Yan, Zheng wrote: > >> On May 6, 2016, at 15:14, Zhang Zhuoyu >> wrote: >> >> Hi, Yan, Viro >> >> Any other comments on this updated version? > > I have no comment for the cephfs part. > > Ilya, do you like the libceph part? I'd leave off rados.h hunk - it's sha

Re: [PATCH v2 1/1] fs/ceph: make logical calculation functions return bool

2016-05-06 Thread Yan, Zheng
--- >> From: hellozzy1...@126.com [mailto:hellozzy1...@126.com] On Behalf Of >> Zhang Zhuoyu >> Sent: Friday, March 25, 2016 5:19 PM >> To: ceph-de...@vger.kernel.org >> Cc: s...@redhat.com; z...@redhat.com; idryo...@gmail.com; linux- >> ker...@vger.kernel.o

RE: [PATCH v2 1/1] fs/ceph: make logical calculation functions return bool

2016-05-06 Thread Zhang Zhuoyu
m; z...@redhat.com; idryo...@gmail.com; linux- > ker...@vger.kernel.org; Zhang Zhuoyu > > Subject: [PATCH v2 1/1] fs/ceph: make logical calculation functions return > bool > > This patch makes serverl logical caculation functions return bool to improve > readability due to these

[PATCH v2 1/1] fs/ceph: make logical calculation functions return bool

2016-03-25 Thread Zhang Zhuoyu
This patch makes serverl logical caculation functions return bool to improve readability due to these particular functions only using 0/1 as their return value. No functional change. -- v2 changelog: ceph_ino_compare() is used by ilookup5, and ilookup5() wants function pointer int (*test)(struct i