Re: [PATCH v2 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-31 Thread Kevin Hilman
Oleksandr Dmytryshyn writes: > On 05/30/2013 07:46 PM, Kevin Hilman wrote: >> Oleksandr Dmytryshyn writes: >> >>> If the i2c controller during suspend will generate an interrupt, it >>> can lead to unpredictable behaviour in the kernel. >>> >>> Based on the logic of the kernel code interrupts fr

Re: [PATCH v2 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-31 Thread Oleksandr Dmytryshyn
On 05/30/2013 07:46 PM, Kevin Hilman wrote: Oleksandr Dmytryshyn writes: If the i2c controller during suspend will generate an interrupt, it can lead to unpredictable behaviour in the kernel. Based on the logic of the kernel code interrupts from i2c should be prohibited during suspend. Kernel

Re: [PATCH v2 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-30 Thread Kevin Hilman
Oleksandr Dmytryshyn writes: > If the i2c controller during suspend will generate an interrupt, it > can lead to unpredictable behaviour in the kernel. > > Based on the logic of the kernel code interrupts from i2c should be > prohibited during suspend. Kernel writes 0 to the I2C_IE register in >

[PATCH v2 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-30 Thread Oleksandr Dmytryshyn
If the i2c controller during suspend will generate an interrupt, it can lead to unpredictable behaviour in the kernel. Based on the logic of the kernel code interrupts from i2c should be prohibited during suspend. Kernel writes 0 to the I2C_IE register in the omap_i2c_runtime_suspend() function. I