Re: [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-07 Thread Alexander Duyck
On Wed, Aug 7, 2019 at 6:58 PM Jacob Wen wrote: > > > On 8/7/19 4:38 PM, Firo Yang wrote: > > The 08/07/2019 15:56, Jacob Wen wrote: > >> I think the description is not correct. Consider using something like > >> below. > > Thank you for comments. > > > >> In Xen environment, due to memory

Re: [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-07 Thread Jacob Wen
On 8/7/19 4:38 PM, Firo Yang wrote: The 08/07/2019 15:56, Jacob Wen wrote: I think the description is not correct. Consider using something like below. Thank you for comments. In Xen environment, due to memory fragmentation ixgbe may allocate a 'DMA' buffer with pages that are not

Re: [Intel-wired-lan] [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-07 Thread Firo Yang
The 08/07/2019 09:06, Alexander Duyck wrote: > On Wed, Aug 7, 2019 at 7:09 AM Maciej Fijalkowski > wrote: > > > > On Wed, 7 Aug 2019 08:38:43 + > > Firo Yang wrote: > > > > > The 08/07/2019 15:56, Jacob Wen wrote: > > > > I think the description is not correct. Consider using something like

Re: [Intel-wired-lan] [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-07 Thread Alexander Duyck
On Wed, Aug 7, 2019 at 7:09 AM Maciej Fijalkowski wrote: > > On Wed, 7 Aug 2019 08:38:43 + > Firo Yang wrote: > > > The 08/07/2019 15:56, Jacob Wen wrote: > > > I think the description is not correct. Consider using something like > > > below. > > Thank you for comments. > > > > > > > > In

Re: [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-07 Thread Firo Yang
The 08/07/2019 15:56, Jacob Wen wrote: > I think the description is not correct. Consider using something like below. Thank you for comments. > > In Xen environment, due to memory fragmentation ixgbe may allocate a 'DMA' > buffer with pages that are not physically contiguous. Actually, I didn't

Re: [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-07 Thread Jacob Wen
I think the description is not correct. Consider using something like below. In Xen environment, due to memory fragmentation ixgbe may allocate a 'DMA' buffer with pages that are not physically contiguous. A NIC doesn't support directly write such buffer. So xen-swiotlb would use the pages,

[PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-06 Thread Firo Yang
In Xen environment, if Xen-swiotlb is enabled, ixgbe driver could possibly allocate a page, DMA memory buffer, for the first fragment which is not suitable for Xen-swiotlb to do DMA operations. Xen-swiotlb have to internally allocate another page for doing DMA operations. It requires syncing