Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

Hi Jia, [auto build test ERROR on nfsd/nfsd-next] [also build test ERROR on v4.9 next-20161209] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

Hi Jia, [auto build test ERROR on nfsd/nfsd-next] [also build test ERROR on v4.9 next-20161209] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

Hi Xinhui Thanks, it really works. Will send out V3 soon afterwards B.R. Jia On 12/12/16 1:43 AM, Pan Xinhui wrote: hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

Hi Xinhui Thanks, it really works. Will send out V3 soon afterwards B.R. Jia On 12/12/16 1:43 AM, Pan Xinhui wrote: hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

在 2016/12/12 01:43, Pan Xinhui 写道: hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :)

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

在 2016/12/12 01:43, Pan Xinhui 写道: hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :)

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index

[PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

nsm_use_hostnames is a module paramter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc items.

[PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

nsm_use_hostnames is a module paramter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc items.