Re: [PATCH v2 1/1] perf tools: Check access permission when reading /proc/kcore file.

2015-06-18 Thread Li Zhang
On 2015年06月18日 13:56, Sukadev Bhattiprolu wrote: Li Zhang [zhlci...@linux.vnet.ibm.com] wrote: | >For consistency with rest of the file, use pr_warning() or pr_err(). | | ui_warning can report the message to users directly when this | program is running. | But if we considered the consistency,

Re: [PATCH v2 1/1] perf tools: Check access permission when reading /proc/kcore file.

2015-06-18 Thread Li Zhang
On 2015年06月18日 13:56, Sukadev Bhattiprolu wrote: Li Zhang [zhlci...@linux.vnet.ibm.com] wrote: | For consistency with rest of the file, use pr_warning() or pr_err(). | | ui_warning can report the message to users directly when this | program is running. | But if we considered the consistency,

Re: [PATCH v2 1/1] perf tools: Check access permission when reading /proc/kcore file.

2015-06-17 Thread Sukadev Bhattiprolu
Li Zhang [zhlci...@linux.vnet.ibm.com] wrote: | >For consistency with rest of the file, use pr_warning() or pr_err(). | | ui_warning can report the message to users directly when this | program is running. | But if we considered the consistency, pr_warning or pr_err should be better. | And users

Re: [PATCH v2 1/1] perf tools: Check access permission when reading /proc/kcore file.

2015-06-17 Thread Li Zhang
On 2015年06月17日 14:09, Sukadev Bhattiprolu wrote: Li Zhang [zhlci...@linux.vnet.ibm.com] wrote: | When using command perf report --kallsyms=/proc/kallsyms with a non-root | user, symbols are resolved. Then select one symbol and annotate it, it | reports the error as the following: | Can't

Re: [PATCH v2 1/1] perf tools: Check access permission when reading /proc/kcore file.

2015-06-17 Thread Sukadev Bhattiprolu
Li Zhang [zhlci...@linux.vnet.ibm.com] wrote: | When using command perf report --kallsyms=/proc/kallsyms with a non-root | user, symbols are resolved. Then select one symbol and annotate it, it | reports the error as the following: | Can't annotate __clear_user: No vmlinux file with build id xxx

Re: [PATCH v2 1/1] perf tools: Check access permission when reading /proc/kcore file.

2015-06-17 Thread Li Zhang
On 2015年06月17日 14:09, Sukadev Bhattiprolu wrote: Li Zhang [zhlci...@linux.vnet.ibm.com] wrote: | When using command perf report --kallsyms=/proc/kallsyms with a non-root | user, symbols are resolved. Then select one symbol and annotate it, it | reports the error as the following: | Can't

Re: [PATCH v2 1/1] perf tools: Check access permission when reading /proc/kcore file.

2015-06-17 Thread Sukadev Bhattiprolu
Li Zhang [zhlci...@linux.vnet.ibm.com] wrote: | For consistency with rest of the file, use pr_warning() or pr_err(). | | ui_warning can report the message to users directly when this | program is running. | But if we considered the consistency, pr_warning or pr_err should be better. | And users

Re: [PATCH v2 1/1] perf tools: Check access permission when reading /proc/kcore file.

2015-06-17 Thread Sukadev Bhattiprolu
Li Zhang [zhlci...@linux.vnet.ibm.com] wrote: | When using command perf report --kallsyms=/proc/kallsyms with a non-root | user, symbols are resolved. Then select one symbol and annotate it, it | reports the error as the following: | Can't annotate __clear_user: No vmlinux file with build id xxx