Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-25 Thread Tony Krowiak
On 2/25/21 10:35 AM, Halil Pasic wrote: On Thu, 25 Feb 2021 10:25:24 -0500 Tony Krowiak wrote: On 2/25/21 8:53 AM, Tony Krowiak wrote: On 2/25/21 6:28 AM, Halil Pasic wrote: On Wed, 24 Feb 2021 22:28:50 -0500 Tony Krowiak wrote: static void vfio_ap_mdev_unset_kvm(struct

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-25 Thread Halil Pasic
On Thu, 25 Feb 2021 08:53:50 -0500 Tony Krowiak wrote: > If we add the proposed flag to indicate when the matrix_mdev->kvm > pointer is in flux, then we can check that before allowing the functions > in the list above to proceed. I'm not against that. Go ahead! Regards, Halil

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-25 Thread Halil Pasic
On Thu, 25 Feb 2021 10:25:24 -0500 Tony Krowiak wrote: > On 2/25/21 8:53 AM, Tony Krowiak wrote: > > > > > > On 2/25/21 6:28 AM, Halil Pasic wrote: > >> On Wed, 24 Feb 2021 22:28:50 -0500 > >> Tony Krowiak wrote: > >> > >static void vfio_ap_mdev_unset_kvm(struct ap_matrix_mdev >

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-25 Thread Tony Krowiak
On 2/25/21 8:53 AM, Tony Krowiak wrote: On 2/25/21 6:28 AM, Halil Pasic wrote: On Wed, 24 Feb 2021 22:28:50 -0500 Tony Krowiak wrote: static void vfio_ap_mdev_unset_kvm(struct ap_matrix_mdev *matrix_mdev) { - kvm_arch_crypto_clear_masks(matrix_mdev->kvm); -

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-25 Thread Halil Pasic
On Wed, 24 Feb 2021 22:28:50 -0500 Tony Krowiak wrote: > >> static void vfio_ap_mdev_unset_kvm(struct ap_matrix_mdev *matrix_mdev) > >> { > >> - kvm_arch_crypto_clear_masks(matrix_mdev->kvm); > >> - matrix_mdev->kvm->arch.crypto.pqap_hook = NULL; > >> -

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-24 Thread Tony Krowiak
On 2/24/21 11:10 AM, Christian Borntraeger wrote: On 23.02.21 10:48, Halil Pasic wrote: On Mon, 15 Feb 2021 20:15:47 -0500 Tony Krowiak wrote: This patch fixes a circular locking dependency in the CI introduced by commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-24 Thread Christian Borntraeger
On 23.02.21 10:48, Halil Pasic wrote: > On Mon, 15 Feb 2021 20:15:47 -0500 > Tony Krowiak wrote: > >> This patch fixes a circular locking dependency in the CI introduced by >> commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM >> pointer invalidated"). The lockdep only

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-23 Thread Halil Pasic
On Mon, 15 Feb 2021 20:15:47 -0500 Tony Krowiak wrote: > This patch fixes a circular locking dependency in the CI introduced by > commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM > pointer invalidated"). The lockdep only occurs when starting a Secure > Execution guest.

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-19 Thread Tony Krowiak
On 2/19/21 8:45 AM, Cornelia Huck wrote: On Mon, 15 Feb 2021 20:15:47 -0500 Tony Krowiak wrote: This patch fixes a circular locking dependency in the CI introduced by commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated"). The lockdep only occurs when

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-19 Thread Cornelia Huck
On Mon, 15 Feb 2021 20:15:47 -0500 Tony Krowiak wrote: > This patch fixes a circular locking dependency in the CI introduced by > commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM > pointer invalidated"). The lockdep only occurs when starting a Secure > Execution guest.

[PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-15 Thread Tony Krowiak
This patch fixes a circular locking dependency in the CI introduced by commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated"). The lockdep only occurs when starting a Secure Execution guest. Crypto virtualization (vfio_ap) is not yet supported for SE guests;