Re: [PATCH v2 1/1] tty: serial: owl: Add support for kernel debugger

2021-01-08 Thread Cristian Ciocaltea
On Fri, Jan 08, 2021 at 08:58:38AM +0100, Jiri Slaby wrote: > On 07. 01. 21, 19:16, Cristian Ciocaltea wrote: > > Hi Greg, > > > > Thank you for the review! > > > > On Thu, Jan 07, 2021 at 04:20:55PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Jan 05, 2021 at 07:02:02PM +0200, Cristian

Re: [PATCH v2 1/1] tty: serial: owl: Add support for kernel debugger

2021-01-07 Thread Jiri Slaby
On 07. 01. 21, 19:16, Cristian Ciocaltea wrote: Hi Greg, Thank you for the review! On Thu, Jan 07, 2021 at 04:20:55PM +0100, Greg Kroah-Hartman wrote: On Tue, Jan 05, 2021 at 07:02:02PM +0200, Cristian Ciocaltea wrote: Implement 'poll_put_char' and 'poll_get_char' callbacks in struct

Re: [PATCH v2 1/1] tty: serial: owl: Add support for kernel debugger

2021-01-07 Thread Cristian Ciocaltea
Hi Greg, Thank you for the review! On Thu, Jan 07, 2021 at 04:20:55PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 05, 2021 at 07:02:02PM +0200, Cristian Ciocaltea wrote: > > Implement 'poll_put_char' and 'poll_get_char' callbacks in struct > > 'owl_uart_ops' that enables OWL UART to be used

Re: [PATCH v2 1/1] tty: serial: owl: Add support for kernel debugger

2021-01-07 Thread Greg Kroah-Hartman
On Tue, Jan 05, 2021 at 07:02:02PM +0200, Cristian Ciocaltea wrote: > Implement 'poll_put_char' and 'poll_get_char' callbacks in struct > 'owl_uart_ops' that enables OWL UART to be used for kernel debugging > over serial line. > > Signed-off-by: Cristian Ciocaltea > --- > Changes in v2: > -

[PATCH v2 1/1] tty: serial: owl: Add support for kernel debugger

2021-01-05 Thread Cristian Ciocaltea
Implement 'poll_put_char' and 'poll_get_char' callbacks in struct 'owl_uart_ops' that enables OWL UART to be used for kernel debugging over serial line. Signed-off-by: Cristian Ciocaltea --- Changes in v2: - Reverted unnecessary changes per Andreas feedback - Optimized implementation for