Re: [PATCH v2 1/1] uprobes: Use percpu_rw_semaphore to fix register/unregister vs dup_mmap() race

2012-11-14 Thread Srikar Dronamraju
* Oleg Nesterov [2012-11-14 19:49:53]: > This was always racy, but 268720903f87e0b84b161626c4447b81671b5d18 > "uprobes: Rework register_for_each_vma() to make it O(n)" should be > blamed anyway, it made everything worse and I didn't notice. > > register/unregister call build_map_info() and then

[PATCH v2 1/1] uprobes: Use percpu_rw_semaphore to fix register/unregister vs dup_mmap() race

2012-11-14 Thread Oleg Nesterov
This was always racy, but 268720903f87e0b84b161626c4447b81671b5d18 "uprobes: Rework register_for_each_vma() to make it O(n)" should be blamed anyway, it made everything worse and I didn't notice. register/unregister call build_map_info() and then do install/remove breakpoint for every mm which

[PATCH v2 1/1] uprobes: Use percpu_rw_semaphore to fix register/unregister vs dup_mmap() race

2012-11-14 Thread Oleg Nesterov
This was always racy, but 268720903f87e0b84b161626c4447b81671b5d18 uprobes: Rework register_for_each_vma() to make it O(n) should be blamed anyway, it made everything worse and I didn't notice. register/unregister call build_map_info() and then do install/remove breakpoint for every mm which

Re: [PATCH v2 1/1] uprobes: Use percpu_rw_semaphore to fix register/unregister vs dup_mmap() race

2012-11-14 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2012-11-14 19:49:53]: This was always racy, but 268720903f87e0b84b161626c4447b81671b5d18 uprobes: Rework register_for_each_vma() to make it O(n) should be blamed anyway, it made everything worse and I didn't notice. register/unregister call build_map_info()