On 24/01/15 21:56, Bryan O'Donoghue wrote:
+
+ if ((imr_to_phys(imr.addr_lo) == base) &&
+ (imr_to_phys(imr.addr_hi) == max)) {
I think we need to take care of the size that has been fix-up here ...
+ found = 1;
+
On 24/01/15 11:02, Andy Shevchenko wrote:
On Sat, Jan 24, 2015 at 3:48 AM, Ong, Boon Leong
wrote:
+static int imr_enabled(struct imr_regs *imr)
Do we want to make it inline perhaps since it is 1 liner?
Since it is declared static I would even suggest the new name is_imr_enabled().
I think
On 24/01/15 01:48, Ong, Boon Leong wrote:
Skipping stuff I agree with.
From V1 comment:
Suggest to add a statement on 3 different types of IMR: General IMR, Host Memory
I/O Boundary IMR & System Management Mode IMR. Then, call out that this patch
is meant to support general IMR type only.
Hm
On Sat, Jan 24, 2015 at 3:48 AM, Ong, Boon Leong
wrote:
>>+static int imr_enabled(struct imr_regs *imr)
> Do we want to make it inline perhaps since it is 1 liner?
Since it is declared static I would even suggest the new name is_imr_enabled().
[]
>>+int imr_remove_range(int reg, unsigned long
.com; x...@kernel.org;
>dvh...@infradead.org; andy.shevche...@gmail.com; Ong, Boon Leong; linux-
>ker...@vger.kernel.org
>Cc: Bryan O'Donoghue
>Subject: [PATCH v2 1/1] x86: Add Isolated Memory Regions for Quark X1000
>
>From V1 comment:
Suggest to add a statement on 3 differen
On Thu, 22 Jan 2015, Bryan O'Donoghue wrote:
> On 22/01/15 15:02, Bryan O'Donoghue wrote:
> >
> > > drivers/platform/x86/intel_qrk_imr.c
> > >
> > > Darren - would that be acceptable to you ?
> >
> > Sorry guys typo - should read arch/x86/platform/imr.c
> >
> > :)
>
> Ah Thomas actually if I'm
On Thu, Jan 22, 2015 at 03:15:26PM +, Bryan O'Donoghue wrote:
> On 22/01/15 15:02, Bryan O'Donoghue wrote:
> >
> >>drivers/platform/x86/intel_qrk_imr.c
> >>
> >>Darren - would that be acceptable to you ?
> >
> >Sorry guys typo - should read arch/x86/platform/imr.c
> >
> >:)
>
> Ah Thomas actua
On 22/01/15 15:02, Bryan O'Donoghue wrote:
drivers/platform/x86/intel_qrk_imr.c
Darren - would that be acceptable to you ?
Sorry guys typo - should read arch/x86/platform/imr.c
:)
Ah Thomas actually if I'm understanding you correctly here
The intention would be to add arch/x86/platform/i
drivers/platform/x86/intel_qrk_imr.c
Darren - would that be acceptable to you ?
Sorry guys typo - should read arch/x86/platform/imr.c
:)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at h
On 22/01/15 11:24, Thomas Gleixner wrote:
On Wed, 21 Jan 2015, Bryan O'Donoghue wrote:
arch/x86/Kconfig | 25 ++
arch/x86/Kconfig.debug | 13 +
arch/x86/include/asm/imr.h | 60
arch/x86/kernel/Makefile | 1 +
arch/x86/kernel/imr.c | 681 ++
On Wed, 21 Jan 2015, Bryan O'Donoghue wrote:
> arch/x86/Kconfig | 25 ++
> arch/x86/Kconfig.debug | 13 +
> arch/x86/include/asm/imr.h | 60
> arch/x86/kernel/Makefile | 1 +
> arch/x86/kernel/imr.c | 681
> +
Can we pleas
On 22/01/15 08:59, Andy Shevchenko wrote:
It was size >> 10 for V1 and you called it out as a magic number :)
IMO, size / 1024 requires less thought to understand when reading the code.
Oh, my bad. Now a bit modified suggestion, to add KiB inside format
string and leave / 1024. Would it work
On Thu, Jan 22, 2015 at 3:27 AM, Bryan O'Donoghue
wrote:
> On 21/01/15 20:57, Andy Shevchenko wrote:
[]
>>> + ret = iosf_mbi_write(QRK_MBI_UNIT_MM, QRK_MBI_MM_WRITE,
>>> + reg++, imr->rmask);
>>> + if (ret)
>>> + goto done;
>>> +
>>> +
On 21/01/15 20:57, Andy Shevchenko wrote:
Few nitpicks and comments below.
+/*
+ * IMR agent access mask bits
+ * See section 12.7.4.7 from quark-x1000-datasheet.pdf for register
+ * definitions
What about dots at the end of sentences?
Murphy's law says - no matter how many times you proof
On Wed, Jan 21, 2015 at 8:46 PM, Bryan O'Donoghue
wrote:
> Intel's Quark X1000 SoC contains a set of registers called Isolated Memory
> Regions. IMRs are accessed over the IOSF mailbox interface. IMRs are areas
> carved out of memory that define read/write access rights to the various
> system age
Intel's Quark X1000 SoC contains a set of registers called Isolated Memory
Regions. IMRs are accessed over the IOSF mailbox interface. IMRs are areas
carved out of memory that define read/write access rights to the various
system agents within the Quark system. For a given agent in the system it is
16 matches
Mail list logo
