Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver

2013-08-08 Thread Nguyen Viet Dung
Hi Wolffam Thank for your advice. I have understand what you have guided. Time of 08/10~08/18 day is summer holiday in Japan. Affter summer holiday, I am going modify the patch, and send again. At that time,please check it for me. Thanks, Dung On 08/08/2013 05:12 PM, Wolfram Sang wrote: On

Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver

2013-08-08 Thread Wolfram Sang
On Thu, Aug 08, 2013 at 10:13:16AM +0900, Nguyen Viet Dung wrote: > Difference between H2 and H1 in hardware is only CDF bit of ICCCR register. No IP version register? Sigh... > If this method is not a common method, please tell me about common method. Use a new platform_device_id and populate

Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver

2013-08-08 Thread Wolfram Sang
On Thu, Aug 08, 2013 at 10:13:16AM +0900, Nguyen Viet Dung wrote: Difference between H2 and H1 in hardware is only CDF bit of ICCCR register. No IP version register? Sigh... If this method is not a common method, please tell me about common method. Use a new platform_device_id and populate

Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver

2013-08-08 Thread Nguyen Viet Dung
Hi Wolffam Thank for your advice. I have understand what you have guided. Time of 08/10~08/18 day is summer holiday in Japan. Affter summer holiday, I am going modify the patch, and send again. At that time,please check it for me. Thanks, Dung On 08/08/2013 05:12 PM, Wolfram Sang wrote: On

Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver

2013-08-07 Thread Wolfram Sang
On Mon, Aug 05, 2013 at 04:19:34PM +0900, Nguyen Viet Dung wrote: > This patch modify I2C driver of rcar-H1 to usable on both rcar-H1 and rcar-H2. > > Signed-off-by: Nguyen Viet Dung Isn't it possible to distinguish between H1 and H2 somewhere in hardware? Then we could skip the 'flags'

Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver

2013-08-07 Thread Wolfram Sang
On Mon, Aug 05, 2013 at 04:19:34PM +0900, Nguyen Viet Dung wrote: This patch modify I2C driver of rcar-H1 to usable on both rcar-H1 and rcar-H2. Signed-off-by: Nguyen Viet Dung nv-d...@jinso.co.jp Isn't it possible to distinguish between H1 and H2 somewhere in hardware? Then we could skip the