Re: [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization

2017-01-04 Thread Ioan-Adrian Ratiu
On Wed, 04 Jan 2017, Takashi Iwai wrote: > On Mon, 02 Jan 2017 16:50:30 +0100, > Ioan-Adrian Ratiu wrote: >> >> --- a/sound/usb/pcm.c >> +++ b/sound/usb/pcm.c > (snip) >> @@ -850,7 +850,7 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream >> *substream) >> /* for

Re: [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization

2017-01-04 Thread Ioan-Adrian Ratiu
On Wed, 04 Jan 2017, Takashi Iwai wrote: > On Mon, 02 Jan 2017 16:50:30 +0100, > Ioan-Adrian Ratiu wrote: >> >> --- a/sound/usb/pcm.c >> +++ b/sound/usb/pcm.c > (snip) >> @@ -850,7 +850,7 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream >> *substream) >> /* for playback, submit

Re: [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization

2017-01-03 Thread Takashi Iwai
On Mon, 02 Jan 2017 16:50:30 +0100, Ioan-Adrian Ratiu wrote: > > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c (snip) > @@ -850,7 +850,7 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream > *substream) > /* for playback, submit the URBs now; otherwise, the first hwptr_done >

Re: [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization

2017-01-03 Thread Takashi Iwai
On Mon, 02 Jan 2017 16:50:30 +0100, Ioan-Adrian Ratiu wrote: > > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c (snip) > @@ -850,7 +850,7 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream > *substream) > /* for playback, submit the URBs now; otherwise, the first hwptr_done >

[PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization

2017-01-02 Thread Ioan-Adrian Ratiu
Commit 16200948d83 ("ALSA: usb-audio: Fix race at stopping the stream") was incomplete causing another more severe kernel panic, so it got reverted. This fixes both the original problem and its fallout kernel race/crash. The original fix is to move the endpoint member NULL clearing logic inside

[PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization

2017-01-02 Thread Ioan-Adrian Ratiu
Commit 16200948d83 ("ALSA: usb-audio: Fix race at stopping the stream") was incomplete causing another more severe kernel panic, so it got reverted. This fixes both the original problem and its fallout kernel race/crash. The original fix is to move the endpoint member NULL clearing logic inside