Re: [PATCH v2 1/2] ARM: tegra: apalis/colibri t30: integrate audio support

2014-09-12 Thread Marcel Ziswiler
On Wed, 2014-09-10 at 15:26 -0600, Stephen Warren wrote: > No, definitely not; this patch has significant semantic changes since I > reviewed it. OK, sorry. Admittedly this was probably a little bit too quick a shot. The solution looked so clean and on first sight worked just fine. > I'm not

Re: [PATCH v2 1/2] ARM: tegra: apalis/colibri t30: integrate audio support

2014-09-12 Thread Marcel Ziswiler
On Wed, 2014-09-10 at 15:26 -0600, Stephen Warren wrote: No, definitely not; this patch has significant semantic changes since I reviewed it. OK, sorry. Admittedly this was probably a little bit too quick a shot. The solution looked so clean and on first sight worked just fine. I'm not sure

Re: [PATCH v2 1/2] ARM: tegra: apalis/colibri t30: integrate audio support

2014-09-10 Thread Stephen Warren
On 09/10/2014 02:54 PM, Marcel Ziswiler wrote: Integrate Freescale SGTL5000 analogue audio codec support. Signed-off-by: Marcel Ziswiler Reviewed-by: Stephen Warren No, definitely not; this patch has significant semantic changes since I reviewed it. diff --git

[PATCH v2 1/2] ARM: tegra: apalis/colibri t30: integrate audio support

2014-09-10 Thread Marcel Ziswiler
Integrate Freescale SGTL5000 analogue audio codec support. Signed-off-by: Marcel Ziswiler Reviewed-by: Stephen Warren --- Changes in v2: - Using simple-audio-card as suggested by Fabio. arch/arm/boot/dts/tegra30-apalis.dtsi | 65 ++

[PATCH v2 1/2] ARM: tegra: apalis/colibri t30: integrate audio support

2014-09-10 Thread Marcel Ziswiler
Integrate Freescale SGTL5000 analogue audio codec support. Signed-off-by: Marcel Ziswiler mar...@ziswiler.com Reviewed-by: Stephen Warren swar...@nvidia.com --- Changes in v2: - Using simple-audio-card as suggested by Fabio. arch/arm/boot/dts/tegra30-apalis.dtsi | 65

Re: [PATCH v2 1/2] ARM: tegra: apalis/colibri t30: integrate audio support

2014-09-10 Thread Stephen Warren
On 09/10/2014 02:54 PM, Marcel Ziswiler wrote: Integrate Freescale SGTL5000 analogue audio codec support. Signed-off-by: Marcel Ziswiler mar...@ziswiler.com Reviewed-by: Stephen Warren swar...@nvidia.com No, definitely not; this patch has significant semantic changes since I reviewed it.