Re: [PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete

2021-01-21 Thread Mark Brown
On Thu, 21 Jan 2021 18:16:43 +0100, Ricardo Ribalda wrote: > If dobj->control is not initialized we end up in an OOPs during > skl_tplg_complete: > > [ 26.553358] BUG: kernel NULL pointer dereference, address: > 0078 > [ 26.561151] #PF: supervisor read access in kernel mode > [ 2

Re: [PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete

2021-01-21 Thread Andy Shevchenko
On Thu, Jan 21, 2021 at 06:16:43PM +0100, Ricardo Ribalda wrote: > If dobj->control is not initialized we end up in an OOPs during > skl_tplg_complete: > > [ 26.553358] BUG: kernel NULL pointer dereference, address: > 0078 > [ 26.561151] #PF: supervisor read access in kernel mode >

Re: [PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete

2021-01-21 Thread Łukasz Majczak
Thanks Ricardo - I have checked it on Eve/Google Pixelbook Tested-by: Lukasz Majczak czw., 21 sty 2021 o 18:33 Rojewski, Cezary napisał(a): > > On 2021-01-21 6:16 PM, Ricardo Ribalda wrote: > > If dobj->control is not initialized we end up in an OOPs during > > skl_tplg_complete: > > > > [ 26

RE: [PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete

2021-01-21 Thread Rojewski, Cezary
On 2021-01-21 6:16 PM, Ricardo Ribalda wrote: > If dobj->control is not initialized we end up in an OOPs during > skl_tplg_complete: > > [ 26.553358] BUG: kernel NULL pointer dereference, address: > 0078 > [ 26.561151] #PF: supervisor read access in kernel mode > [ 26.566897] #PF

Re: [PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete

2021-01-21 Thread Ricardo Ribalda
Hi, This is just a v2 from my patch from December with the ={}: in a second patch. Best regards! On Thu, Jan 21, 2021 at 6:16 PM Ricardo Ribalda wrote: > > If dobj->control is not initialized we end up in an OOPs during > skl_tplg_complete: > > [ 26.553358] BUG: kernel NULL pointer dereferen

[PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete

2021-01-21 Thread Ricardo Ribalda
If dobj->control is not initialized we end up in an OOPs during skl_tplg_complete: [ 26.553358] BUG: kernel NULL pointer dereference, address: 0078 [ 26.561151] #PF: supervisor read access in kernel mode [ 26.566897] #PF: error_code(0x) - not-present page [ 26.572642] PGD 0