Hello Mark,
Thanks for the review.
On Mon, 5 Mar 2018 15:59:38 +
Mark Brown wrote:
> On Mon, Mar 05, 2018 at 04:57:15PM +0100, Alexandre Belloni wrote:
> > On 05/03/2018 at 15:49:10 +, Mark Brown wrote:
>
> > > Please don't mix C and C++ style comments in a single comment like this
>
On Mon, Mar 05, 2018 at 04:57:15PM +0100, Alexandre Belloni wrote:
> On 05/03/2018 at 15:49:10 +, Mark Brown wrote:
> > Please don't mix C and C++ style comments in a single comment like this
> > - it looks unintentional. Just use the same style for the whole thing.
> > You also don't need to
On 05/03/2018 at 15:49:10 +, Mark Brown wrote:
> On Mon, Mar 05, 2018 at 01:48:16PM +0100, Mylène Josserand wrote:
>
> > --- /dev/null
> > +++ b/sound/soc/codecs/pcm1789-i2c.c
> > @@ -0,0 +1,76 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * PCM1789 ASoC I2C driver
> > + *
> > + *
On Mon, Mar 05, 2018 at 01:48:16PM +0100, Mylène Josserand wrote:
> --- /dev/null
> +++ b/sound/soc/codecs/pcm1789-i2c.c
> @@ -0,0 +1,76 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * PCM1789 ASoC I2C driver
> + *
> + * Copyright (c) Bootlin 2018
> + *
> + * Mylène Josserand
> + *
> + * Th
Add Texas Instruments's PCM1789 DAC support.
It is a simple DAC and does not have many registers.
One particularity about this DAC is that the clocks must be
always enabled. Also, an entire software reset is necessary
while starting to play a sound otherwise, the clocks are not
synchronized (so th
5 matches
Mail list logo
