Re: [PATCH v2 1/2] MIPS: Loongson: Cleanup cpu_hwmon.c

2020-05-09 Thread Tiezhu Yang
On 05/09/2020 05:52 PM, Huacai Chen wrote: Hi, Tiezhu, On Sat, May 9, 2020 at 3:13 PM Tiezhu Yang wrote: Fix the following checkpatch warnings and errors: ERROR: do not initialise statics to 0 #14: FILE: drivers/platform/mips/cpu_hwmon.c:14: +static int csr_temp_enable = 0; I know you are

Re: [PATCH v2 1/2] MIPS: Loongson: Cleanup cpu_hwmon.c

2020-05-09 Thread Huacai Chen
Hi, Tiezhu, On Sat, May 9, 2020 at 3:13 PM Tiezhu Yang wrote: > > Fix the following checkpatch warnings and errors: > > ERROR: do not initialise statics to 0 > #14: FILE: drivers/platform/mips/cpu_hwmon.c:14: > +static int csr_temp_enable = 0; I know you are doing things by checkpatch, but I

[PATCH v2 1/2] MIPS: Loongson: Cleanup cpu_hwmon.c

2020-05-09 Thread Tiezhu Yang
Fix the following checkpatch warnings and errors: ERROR: do not initialise statics to 0 #14: FILE: drivers/platform/mips/cpu_hwmon.c:14: +static int csr_temp_enable = 0; WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #60: FILE: