Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures

2018-01-08 Thread Prarit Bhargava
[Sorry everyone for the late response, I went away on vacation and pushed this off until I returned.] On 12/13/2017 07:45 AM, Lorenzo Pieralisi wrote: > [+Mark, Graeme] > > In $SUBJECT, s/avialable/available > > On Mon, Dec 11, 2017 at 10:50:58AM -0500, Prarit Bhargava wrote: >> Other architectu

Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures

2017-12-14 Thread Lorenzo Pieralisi
On Thu, Dec 14, 2017 at 08:08:08AM -0600, Timur Tabi wrote: > On 12/14/17 4:30 AM, Lorenzo Pieralisi wrote: > >>I didn't want to put any ACPI code in amba-pl011.c, so putting it in spcr.c > >>made the most sense. I agree the global variable is ugly. If you have a > >>better idea, I'm all ears. >

Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures

2017-12-14 Thread Timur Tabi
On 12/14/17 4:30 AM, Lorenzo Pieralisi wrote: I didn't want to put any ACPI code in amba-pl011.c, so putting it in spcr.c made the most sense. I agree the global variable is ugly. If you have a better idea, I'm all ears. I told you my idea. It could have been made easier by reusing the ACPI_

Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures

2017-12-14 Thread Lorenzo Pieralisi
On Wed, Dec 13, 2017 at 03:11:33PM -0600, Timur Tabi wrote: > On 12/13/2017 06:45 AM, Lorenzo Pieralisi wrote: > >>+/* > >>+ * Erratum 44 for QDF2432v1 and QDF2400v1 SoCs describes the BUSY bit as > >>+ * occasionally getting stuck as 1. To avoid the potential for a hang, > >>check > >>+ * TXFE ==

Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures

2017-12-13 Thread Timur Tabi
On 12/13/2017 06:45 AM, Lorenzo Pieralisi wrote: +/* + * Erratum 44 for QDF2432v1 and QDF2400v1 SoCs describes the BUSY bit as + * occasionally getting stuck as 1. To avoid the potential for a hang, check + * TXFE == 0 instead of BUSY == 1. This may not be suitable for all UART + * implementation

Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures

2017-12-13 Thread Lorenzo Pieralisi
[+Mark, Graeme] In $SUBJECT, s/avialable/available On Mon, Dec 11, 2017 at 10:50:58AM -0500, Prarit Bhargava wrote: > Other architectures can use SPCR to setup an early console or console > but the current code is ARM64 specific. I see nothing ARM64 specific in current code (apart from some ACPI

Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures

2017-12-13 Thread Will Deacon
[adding Lorenzo, Sudeep and Hanjun -- see Rafael's comment below] On Wed, Dec 13, 2017 at 01:22:59AM +0100, Rafael J. Wysocki wrote: > On Monday, December 11, 2017 4:50:58 PM CET Prarit Bhargava wrote: > > Other architectures can use SPCR to setup an early console or console > > but the current co

Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures

2017-12-12 Thread Rafael J. Wysocki
On Monday, December 11, 2017 4:50:58 PM CET Prarit Bhargava wrote: > Other architectures can use SPCR to setup an early console or console > but the current code is ARM64 specific. > > Change the name of parse_spcr() to acpi_parse_spcr(). Add a weak > function acpi_arch_setup_console() that can b

[PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures

2017-12-11 Thread Prarit Bhargava
Other architectures can use SPCR to setup an early console or console but the current code is ARM64 specific. Change the name of parse_spcr() to acpi_parse_spcr(). Add a weak function acpi_arch_setup_console() that can be used for arch-specific setup. Move flags into ACPI code. Update the Docum