Re: [PATCH v2 1/2] compiler-clang.h: Add CLANG_VERSION and __diag macros

2018-08-31 Thread Miguel Ojeda
Hi Nick, On Fri, Aug 31, 2018 at 11:50 PM, Nick Desaulniers wrote: > + Miguel and Joe > > This is the old patch I had sent for detecting Clang version. If we > wanted to set a minimal version, this plus the actual version should > do it. Probably could drop the diag stuff, as we changed clang t

Re: [PATCH v2 1/2] compiler-clang.h: Add CLANG_VERSION and __diag macros

2018-08-31 Thread Nick Desaulniers
+ Miguel and Joe This is the old patch I had sent for detecting Clang version. If we wanted to set a minimal version, this plus the actual version should do it. Probably could drop the diag stuff, as we changed clang to not warn in this case, so my solution using _Pragma is obsolete. On Mon, Jul

Re: [PATCH v2 1/2] compiler-clang.h: Add CLANG_VERSION and __diag macros

2018-07-30 Thread Nathan Chancellor
On Mon, Jul 30, 2018 at 02:34:11PM -0700, Nick Desaulniers wrote: > These are needed for doing proper version checks, though feature > detection via __has_attribute, __has_builtin, and __has_feature should > be preferred, see: > https://clang.llvm.org/docs/LanguageExtensions.html#feature-checking-

[PATCH v2 1/2] compiler-clang.h: Add CLANG_VERSION and __diag macros

2018-07-30 Thread Nick Desaulniers
These are needed for doing proper version checks, though feature detection via __has_attribute, __has_builtin, and __has_feature should be preferred, see: https://clang.llvm.org/docs/LanguageExtensions.html#feature-checking-macros Also adds __diag support, for generating compiler version specific