Re: [PATCH v2 1/2] console: Remove dummy con_font_op() callback implementations

2020-11-02 Thread Peilin Ye
On Mon, Nov 02, 2020 at 11:13:47AM +0100, Daniel Vetter wrote: > On Mon, Nov 02, 2020 at 10:47:55AM +0100, Jiri Slaby wrote: > > On 02. 11. 20, 10:36, Peilin Ye wrote: > > > `struct console_font` is a UAPI structure, thus ideally should not be > > > used for kernel internal abstraction. Remove

Re: [PATCH v2 1/2] console: Remove dummy con_font_op() callback implementations

2020-11-02 Thread Daniel Vetter
On Mon, Nov 02, 2020 at 10:47:55AM +0100, Jiri Slaby wrote: > On 02. 11. 20, 10:36, Peilin Ye wrote: > > `struct console_font` is a UAPI structure, thus ideally should not be > > used for kernel internal abstraction. Remove some dummy .con_font_set, > > .con_font_default and .con_font_copy `struct

Re: [PATCH v2 1/2] console: Remove dummy con_font_op() callback implementations

2020-11-02 Thread Jiri Slaby
On 02. 11. 20, 10:36, Peilin Ye wrote: `struct console_font` is a UAPI structure, thus ideally should not be used for kernel internal abstraction. Remove some dummy .con_font_set, .con_font_default and .con_font_copy `struct consw` callback implementations, to make it cleaner. ESEMANTIC_ERROR.

[PATCH v2 1/2] console: Remove dummy con_font_op() callback implementations

2020-11-02 Thread Peilin Ye
`struct console_font` is a UAPI structure, thus ideally should not be used for kernel internal abstraction. Remove some dummy .con_font_set, .con_font_default and .con_font_copy `struct consw` callback implementations, to make it cleaner. Suggested-by: Daniel Vetter Signed-off-by: Peilin Ye ---