Re: [PATCH v2 1/2] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-11 Thread Smita Koralahalli Channabasappa
On 9/11/20 1:23 PM, Ard Biesheuvel wrote: On Thu, 3 Sep 2020 at 09:34, Punit Agrawal wrote: Hi Smita, Smita Koralahalli Channabasappa writes: On 8/31/20 12:05 AM, Punit Agrawal wrote: Hi Smita, A couple of comments below - Smita Koralahalli writes: [...] diff --git

Re: [PATCH v2 1/2] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-11 Thread Ard Biesheuvel
On Thu, 3 Sep 2020 at 09:34, Punit Agrawal wrote: > > Hi Smita, > > Smita Koralahalli Channabasappa writes: > > > On 8/31/20 12:05 AM, Punit Agrawal wrote: > > > >> Hi Smita, > >> > >> A couple of comments below - > >> > >> Smita Koralahalli writes: > >> > >> [...] > >> > >> > >>> diff --git

Re: [PATCH v2 1/2] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-03 Thread Punit Agrawal
Hi Smita, Smita Koralahalli Channabasappa writes: > On 8/31/20 12:05 AM, Punit Agrawal wrote: > >> Hi Smita, >> >> A couple of comments below - >> >> Smita Koralahalli writes: >> >> [...] >> >> >>> diff --git a/drivers/firmware/efi/cper-x86.c >>> b/drivers/firmware/efi/cper-x86.c >>> index

Re: [PATCH v2 1/2] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-02 Thread Smita Koralahalli Channabasappa
On 8/31/20 12:05 AM, Punit Agrawal wrote: Hi Smita, A couple of comments below - Smita Koralahalli writes: [...] diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c index 2531de49f56c..374b8e18552a 100644 --- a/drivers/firmware/efi/cper-x86.c +++

Re: [PATCH v2 1/2] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-01 Thread Yazen Ghannam
On Fri, Aug 28, 2020 at 03:33:31PM -0500, Smita Koralahalli wrote: ... > +int apei_mce_report_x86_error(struct cper_ia_proc_ctx *ctx_info, u64 > lapic_id) > +{ > + const u64 *i_mce = ((const void *) (ctx_info + 1)); > + unsigned int cpu; > + struct mce m; > + > + if

Re: [PATCH v2 1/2] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-08-30 Thread Punit Agrawal
Hi Smita, A couple of comments below - Smita Koralahalli writes: > Linux Kernel uses ACPI Boot Error Record Table (BERT) to report fatal > errors that occurred in a previous boot. The MCA errors in the BERT are > reported using the x86 Processor Error Common Platform Error Record (CPER) >

[PATCH v2 1/2] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-08-28 Thread Smita Koralahalli
Linux Kernel uses ACPI Boot Error Record Table (BERT) to report fatal errors that occurred in a previous boot. The MCA errors in the BERT are reported using the x86 Processor Error Common Platform Error Record (CPER) format. Currently, the record prints out the raw MSR values and AMD relies on the