Re: [PATCH v2 1/2] dmaengine: Add an enum for the dmaengine alignment constraints

2015-08-04 Thread Vinod Koul
On Mon, Jul 20, 2015 at 10:41:32AM +0200, Maxime Ripard wrote: > Most drivers need to set constraints on the buffer alignment for async tx > operations. However, even though it is documented, some drivers either use > a defined constant that is not matching what the alignment variable expects > (li

Re: [PATCH v2 1/2] dmaengine: Add an enum for the dmaengine alignment constraints

2015-07-27 Thread Thomas Petazzoni
Maxime, On Mon, 27 Jul 2015 08:48:04 +0200, Maxime Ripard wrote: > I could, but all the rest of the other similar case so far in > dmaengine are made through enum, so I guess it's still better for > consistency. And we also provide a comprehensive list of the valid > values this way, something a

Re: [PATCH v2 1/2] dmaengine: Add an enum for the dmaengine alignment constraints

2015-07-26 Thread Maxime Ripard
On Mon, Jul 20, 2015 at 11:03:25AM +0200, Thomas Petazzoni wrote: > Maxime, > > On Mon, 20 Jul 2015 10:41:32 +0200, Maxime Ripard wrote: > > > /** > > + * enum dmaengine_alignment - defines alignment of the DMA async tx > > + * buffers > > + */ > > +enum dmaengine_alignment { > > + DMAENGINE_A

Re: [PATCH v2 1/2] dmaengine: Add an enum for the dmaengine alignment constraints

2015-07-20 Thread Thomas Petazzoni
Maxime, On Mon, 20 Jul 2015 10:41:32 +0200, Maxime Ripard wrote: > /** > + * enum dmaengine_alignment - defines alignment of the DMA async tx > + * buffers > + */ > +enum dmaengine_alignment { > + DMAENGINE_ALIGN_1_BYTE = 0, > + DMAENGINE_ALIGN_2_BYTES = 1, > + DMAENGINE_ALIGN_4_BYTE

[PATCH v2 1/2] dmaengine: Add an enum for the dmaengine alignment constraints

2015-07-20 Thread Maxime Ripard
Most drivers need to set constraints on the buffer alignment for async tx operations. However, even though it is documented, some drivers either use a defined constant that is not matching what the alignment variable expects (like DMA_BUSWIDTH_* constants) or fill the alignment in bytes instead of