Re: [PATCH v2 1/2] drivers/dma/iop-adma: Use dma_alloc_writecombine() kernel-style

2015-07-24 Thread Luis R. Rodriguez
On Thu, Jul 23, 2015 at 10:53:57PM +0530, Vinod Koul wrote: > On Thu, Jul 09, 2015 at 06:34:23PM -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > dma_alloc_writecombine()'s call and return value check is tangled in all > > in one call. Untangle both calls according to kernel

Re: [PATCH v2 1/2] drivers/dma/iop-adma: Use dma_alloc_writecombine() kernel-style

2015-07-23 Thread Vinod Koul
On Thu, Jul 09, 2015 at 06:34:23PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > dma_alloc_writecombine()'s call and return value check is tangled in all > in one call. Untangle both calls according to kernel coding style. > This looks okay, does it have dependency on anything

[PATCH v2 1/2] drivers/dma/iop-adma: Use dma_alloc_writecombine() kernel-style

2015-07-09 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" dma_alloc_writecombine()'s call and return value check is tangled in all in one call. Untangle both calls according to kernel coding style. Signed-off-by: Luis R. Rodriguez Cc: Dan Williams Cc: dmaeng...@vger.kernel.org Cc: Vinod Koul Cc: x...@kernel.org Link: http: