Re: [PATCH v2 1/2] exec: add a flag for "reasonable" execveat() comm

2024-10-01 Thread Tycho Andersen
On Mon, Sep 30, 2024 at 03:10:29PM -0500, Eric W. Biederman wrote: > "Eric W. Biederman" writes: > > > Kees Cook writes: > > >> I'm not super comfortable doing this regardless of bprm->fdpath; that > >> seems like too many cases getting changed. Can we just leave it as > >> depending on bprm->f

Re: [PATCH v2 1/2] exec: add a flag for "reasonable" execveat() comm

2024-09-30 Thread Eric W. Biederman
"Eric W. Biederman" writes: > Kees Cook writes: >> I'm not super comfortable doing this regardless of bprm->fdpath; that >> seems like too many cases getting changed. Can we just leave it as >> depending on bprm->fdpath? I was recommending that because I did not expect that there was any wides

Re: [PATCH v2 1/2] exec: add a flag for "reasonable" execveat() comm

2024-09-28 Thread Kees Cook
On Fri, Sep 27, 2024 at 10:45:58AM -0500, Eric W. Biederman wrote: > Tycho Andersen writes: > > > From: Tycho Andersen > > > > Zbigniew mentioned at Linux Plumber's that systemd is interested in > > switching to execveat() for service execution, but can't, because the > > contents of /proc/pid/c

Re: [PATCH v2 1/2] exec: add a flag for "reasonable" execveat() comm

2024-09-27 Thread Eric W. Biederman
Tycho Andersen writes: > From: Tycho Andersen > > Zbigniew mentioned at Linux Plumber's that systemd is interested in > switching to execveat() for service execution, but can't, because the > contents of /proc/pid/comm are the file descriptor which was used, > instead of the path to the binary.

[PATCH v2 1/2] exec: add a flag for "reasonable" execveat() comm

2024-09-27 Thread Tycho Andersen
From: Tycho Andersen Zbigniew mentioned at Linux Plumber's that systemd is interested in switching to execveat() for service execution, but can't, because the contents of /proc/pid/comm are the file descriptor which was used, instead of the path to the binary. This makes the output of tools like