Re: [PATCH v2 1/2] extcon: arizona: Fix reset of HPDET after race with removal

2013-11-04 Thread Chanwoo Choi
On 11/04/2013 06:21 PM, Charles Keepax wrote: > On Mon, Nov 04, 2013 at 09:32:50AM +0900, Chanwoo Choi wrote: >> The arizona_hpdet_do_id() return only either -EAGIN or 0(zero). >> extcon-arizona driver could never execute 'goto done;' statement. >> >> ret = arizona_hpdet_do_id(info, &reading,

Re: [PATCH v2 1/2] extcon: arizona: Fix reset of HPDET after race with removal

2013-11-04 Thread Charles Keepax
On Mon, Nov 04, 2013 at 09:32:50AM +0900, Chanwoo Choi wrote: > The arizona_hpdet_do_id() return only either -EAGIN or 0(zero). > extcon-arizona driver could never execute 'goto done;' statement. > > ret = arizona_hpdet_do_id(info, &reading, &mic); > if (ret == -EAGAIN) { >

Re: [PATCH v2 1/2] extcon: arizona: Fix reset of HPDET after race with removal

2013-11-03 Thread Chanwoo Choi
Hi Charles, On 10/28/2013 01:19 AM, Charles Keepax wrote: > We need to make sure we reset back to our starting state, especially > making sure that we have disabled poll in the register cache. > > Signed-off-by: Charles Keepax > --- > drivers/extcon/extcon-arizona.c |8 +++- > 1 files c

[PATCH v2 1/2] extcon: arizona: Fix reset of HPDET after race with removal

2013-10-27 Thread Charles Keepax
We need to make sure we reset back to our starting state, especially making sure that we have disabled poll in the register cache. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extc