Re: [PATCH v2 1/2] extcon: max77693: Fix return value

2013-03-28 Thread Chanwoo Choi
On 03/28/2013 03:27 PM, Sachin Kamat wrote: > Return the value obtained from the function instead of hardcoding. > Silences the following warnings: > drivers/extcon/extcon-max77693.c:297 max77693_muic_set_path() > info: why not propagate 'ret' from max77693_update_reg() instead of (-11)? >

[PATCH v2 1/2] extcon: max77693: Fix return value

2013-03-28 Thread Sachin Kamat
Return the value obtained from the function instead of hardcoding. Silences the following warnings: drivers/extcon/extcon-max77693.c:297 max77693_muic_set_path() info: why not propagate 'ret' from max77693_update_reg() instead of (-11)? drivers/extcon/extcon-max77693.c:310 max77693_muic_set_path()

Re: [PATCH v2 1/2] extcon: max77693: Fix return value

2013-03-28 Thread Chanwoo Choi
On 03/28/2013 03:27 PM, Sachin Kamat wrote: Return the value obtained from the function instead of hardcoding. Silences the following warnings: drivers/extcon/extcon-max77693.c:297 max77693_muic_set_path() info: why not propagate 'ret' from max77693_update_reg() instead of (-11)?

[PATCH v2 1/2] extcon: max77693: Fix return value

2013-03-28 Thread Sachin Kamat
Return the value obtained from the function instead of hardcoding. Silences the following warnings: drivers/extcon/extcon-max77693.c:297 max77693_muic_set_path() info: why not propagate 'ret' from max77693_update_reg() instead of (-11)? drivers/extcon/extcon-max77693.c:310 max77693_muic_set_path()