Re: [PATCH v2 1/2] hwmon: (ads7828) driver cleanup

2012-10-01 Thread Guenter Roeck
On Mon, Oct 01, 2012 at 10:16:07PM -0400, Vivien Didelot wrote: > Hi Guenter, > [ ... ] > > > > > > -/* Each client has this additional data */ > > > +/** > > > + * struct ads7828_data - client specific data > > > + * @hwmon_dev: The hwmon device. > > > + * @update_lock: Mutex protecti

Re: [PATCH v2 1/2] hwmon: (ads7828) driver cleanup

2012-10-01 Thread Vivien Didelot
Hi Guenter, On Mon, 2012-10-01 at 18:07 -0700, Guenter Roeck wrote: > On Mon, Oct 01, 2012 at 07:16:23PM -0400, Vivien Didelot wrote: > > * Remove unused macros; > > * Point to the documentation; > > * Coding Style fixes (Kernel Doc, spacing); > > * Move driver declaration to avoid adding function

Re: [PATCH v2 1/2] hwmon: (ads7828) driver cleanup

2012-10-01 Thread Guenter Roeck
On Mon, Oct 01, 2012 at 07:16:23PM -0400, Vivien Didelot wrote: > * Remove unused macros; > * Point to the documentation; > * Coding Style fixes (Kernel Doc, spacing); > * Move driver declaration to avoid adding function prototypes. > > Signed-off-by: Vivien Didelot Hi Vivien, > --- > drivers/

[PATCH v2 1/2] hwmon: (ads7828) driver cleanup

2012-10-01 Thread Vivien Didelot
* Remove unused macros; * Point to the documentation; * Coding Style fixes (Kernel Doc, spacing); * Move driver declaration to avoid adding function prototypes. Signed-off-by: Vivien Didelot --- drivers/hwmon/ads7828.c | 91 +++-- 1 file changed, 43 in