Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-10 Thread Singh, Balbir
On 11/3/21 9:00 am, Hugh Dickins wrote: > On Thu, 11 Mar 2021, Singh, Balbir wrote: >> On 9/3/21 7:28 pm, Michal Hocko wrote: >>> On Tue 09-03-21 09:37:29, Balbir Singh wrote: On 4/3/21 6:40 pm, Zhou Guanghui wrote: >>> [...] > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > /* > - * Becaus

Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-10 Thread Hugh Dickins
On Thu, 11 Mar 2021, Singh, Balbir wrote: > On 9/3/21 7:28 pm, Michal Hocko wrote: > > On Tue 09-03-21 09:37:29, Balbir Singh wrote: > >> On 4/3/21 6:40 pm, Zhou Guanghui wrote: > > [...] > >>> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > >>> /* > >>> - * Because page_memcg(head) is not set on compound t

Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-10 Thread Singh, Balbir
On 9/3/21 7:28 pm, Michal Hocko wrote: > On Tue 09-03-21 09:37:29, Balbir Singh wrote: >> On 4/3/21 6:40 pm, Zhou Guanghui wrote: > [...] >>> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE >>> /* >>> - * Because page_memcg(head) is not set on compound tails, set it now. >>> + * Because page_memcg(head) is no

Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-09 Thread Michal Hocko
On Tue 09-03-21 09:37:29, Balbir Singh wrote: > On 4/3/21 6:40 pm, Zhou Guanghui wrote: [...] > > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > /* > > - * Because page_memcg(head) is not set on compound tails, set it now. > > + * Because page_memcg(head) is not set on tails, set it now. > > */ > > -vo

Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-08 Thread Singh, Balbir
On 4/3/21 6:40 pm, Zhou Guanghui wrote: > Rename mem_cgroup_split_huge_fixup to split_page_memcg and explicitly > pass in page number argument. > > In this way, the interface name is more common and can be used by > potential users. In addition, the complete info(memcg and flag) of > the memcg nee

Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-05 Thread Michal Hocko
On Thu 04-03-21 07:40:52, Zhou Guanghui wrote: > Rename mem_cgroup_split_huge_fixup to split_page_memcg and explicitly > pass in page number argument. > > In this way, the interface name is more common and can be used by > potential users. In addition, the complete info(memcg and flag) of > the me

Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-04 Thread Shakeel Butt
On Wed, Mar 3, 2021 at 11:55 PM Zhou Guanghui wrote: > > Rename mem_cgroup_split_huge_fixup to split_page_memcg and explicitly > pass in page number argument. > > In this way, the interface name is more common and can be used by > potential users. In addition, the complete info(memcg and flag) of

Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-04 Thread Zi Yan
On 4 Mar 2021, at 2:40, Zhou Guanghui wrote: > Rename mem_cgroup_split_huge_fixup to split_page_memcg and explicitly > pass in page number argument. > > In this way, the interface name is more common and can be used by > potential users. In addition, the complete info(memcg and flag) of > the memc

Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-04 Thread Johannes Weiner
On Thu, Mar 04, 2021 at 07:40:52AM +, Zhou Guanghui wrote: > Rename mem_cgroup_split_huge_fixup to split_page_memcg and explicitly > pass in page number argument. > > In this way, the interface name is more common and can be used by > potential users. In addition, the complete info(memcg and f

[PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg

2021-03-03 Thread Zhou Guanghui
Rename mem_cgroup_split_huge_fixup to split_page_memcg and explicitly pass in page number argument. In this way, the interface name is more common and can be used by potential users. In addition, the complete info(memcg and flag) of the memcg needs to be set to the tail pages. Signed-off-by: Zhou