Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-09 Thread Michal Hocko
On Tue 09-03-21 08:29:21, Minchan Kim wrote: > On Tue, Mar 09, 2021 at 12:03:08PM +0100, Michal Hocko wrote: [...] > > Sorry for nit picking but I think the additional abstraction for > > migrate_prep is not really needed and we can remove some more code. > > Maybe we should even get rid of

Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-09 Thread Minchan Kim
On Tue, Mar 09, 2021 at 05:31:09PM +0100, David Hildenbrand wrote: > > > > > Signed-off-by: Minchan Kim > > > > --- > > > > * from v1 - > > > > https://lore.kernel.org/lkml/20210302210949.2440120-1-minc...@kernel.org/ > > > >* introduce __lru_add_drain_all to minimize changes - mhocko > > >

Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-09 Thread David Hildenbrand
Signed-off-by: Minchan Kim --- * from v1 - https://lore.kernel.org/lkml/20210302210949.2440120-1-minc...@kernel.org/ * introduce __lru_add_drain_all to minimize changes - mhocko * use lru_cache_disable for memory-hotplug * schedule for every cpu at force_all_cpus * from RFC -

Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-09 Thread Minchan Kim
On Tue, Mar 09, 2021 at 12:03:08PM +0100, Michal Hocko wrote: > On Mon 08-03-21 21:16:27, Minchan Kim wrote: > > LRU pagevec holds refcount of pages until the pagevec are drained. > > It could prevent migration since the refcount of the page is greater > > than the expection in migration logic. To

Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-09 Thread Michal Hocko
On Mon 08-03-21 21:16:27, Minchan Kim wrote: > LRU pagevec holds refcount of pages until the pagevec are drained. > It could prevent migration since the refcount of the page is greater > than the expection in migration logic. To mitigate the issue, > callers of migrate_pages drains LRU pagevec via

Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-09 Thread kernel test robot
Hi Minchan, I love your patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.12-rc2 next-20210309] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-09 Thread kernel test robot
Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.12-rc2 next-20210309] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-08 Thread kernel test robot
Hi Minchan, I love your patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.12-rc2 next-20210309] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-08 Thread Minchan Kim
LRU pagevec holds refcount of pages until the pagevec are drained. It could prevent migration since the refcount of the page is greater than the expection in migration logic. To mitigate the issue, callers of migrate_pages drains LRU pagevec via migrate_prep or lru_add_drain_all before